From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 518B3C43334 for ; Thu, 9 Jun 2022 14:55:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 076D6843B9; Thu, 9 Jun 2022 16:55:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=csgraf.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DF8A5843C7; Thu, 9 Jun 2022 16:55:05 +0200 (CEST) Received: from zulu616.server4you.de (mail.csgraf.de [85.25.223.15]) by phobos.denx.de (Postfix) with ESMTP id 6645F843C1 for ; Thu, 9 Jun 2022 16:55:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=csgraf.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=agraf@csgraf.de Received: from [192.168.106.118] (dynamic-077-004-116-159.77.4.pool.telefonica.de [77.4.116.159]) by csgraf.de (Postfix) with ESMTPSA id BAA5E60801E4; Thu, 9 Jun 2022 16:55:00 +0200 (CEST) Message-ID: <60882a2e-eea7-ea08-e654-c24da0e2e973@csgraf.de> Date: Thu, 9 Jun 2022 16:55:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 5/6] efi_loader: GOP: Add damage notification on BLT Content-Language: en-US To: Heinrich Schuchardt Cc: Anatolij Gustschin , Simon Glass , Matthias Brugger , Da Xue , u-boot@lists.denx.de References: <20220606234336.5021-1-agraf@csgraf.de> <20220606234336.5021-6-agraf@csgraf.de> <1ec8ccce-fc02-35f7-d234-662887f0534b@gmx.de> From: Alexander Graf In-Reply-To: <1ec8ccce-fc02-35f7-d234-662887f0534b@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hey Heinrich, On 07.06.22 09:12, Heinrich Schuchardt wrote: > On 6/7/22 01:43, Alexander Graf wrote: >> Now that we have a damage tracking API, let's populate damage done by >> UEFI payloads when they BLT data onto the screen. >> >> Signed-off-by: Alexander Graf >> Reported-by: Da Xue >> --- >>   lib/efi_loader/efi_gop.c | 11 +++++++++++ >>   1 file changed, 11 insertions(+) >> >> diff --git a/lib/efi_loader/efi_gop.c b/lib/efi_loader/efi_gop.c >> index 2c81859807..67286c9a60 100644 >> --- a/lib/efi_loader/efi_gop.c >> +++ b/lib/efi_loader/efi_gop.c >> @@ -33,6 +33,9 @@ struct efi_gop_obj { >>       struct efi_gop ops; >>       struct efi_gop_mode_info info; >>       struct efi_gop_mode mode; >> +#ifdef CONFIG_DM_VIDEO > > Please, heed the warnings provided by scripts/checkpatch.pl: > > WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' > where possible > #174: FILE: lib/efi_loader/efi_gop.c:36: > +#ifdef CONFIG_DM_VIDEO I was mostly afraid of adding a dependency on struct udevice here. But since we already include video.h, I believe we're good. Happy to change it to only runtime checks. Alex