From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79AC6C77B73 for ; Tue, 2 May 2023 07:27:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6478B8213D; Tue, 2 May 2023 09:27:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="pd7iO2Ra"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 296C38214A; Tue, 2 May 2023 09:27:35 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F8AE82120 for ; Tue, 2 May 2023 09:27:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-kumar1@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3427RS6a067803; Tue, 2 May 2023 02:27:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1683012448; bh=7Wnq0ANfXIcsX4x5qs2nHCV/tUi84evCBShyqJUVGfM=; h=Date:Subject:To:References:From:In-Reply-To; b=pd7iO2RaZLVEXDLBuQx+cY5hElp+KNZsLKTePgSh+3OE8XUOaxovMfrgndP/mk6mz fQ4SZEdV2V+8gwv3n0nV9KjubnEAHVfYNSaKTn3Z6IfKynVoKr2gcoOGUlFBpFgl1i 2b1dgi3XRDg/hrhy02j1KoRA9TsBIEpt39W/ro6g= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3427RSCC086814 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 2 May 2023 02:27:28 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 2 May 2023 02:27:28 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 2 May 2023 02:27:28 -0500 Received: from [172.24.216.133] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3427RPom028389; Tue, 2 May 2023 02:27:26 -0500 Message-ID: <6198aa4e-126e-7b58-792f-36cb799a52af@ti.com> Date: Tue, 2 May 2023 12:57:25 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2] arch: arm: mach-k3: Delete tifs node in DT fixup To: Andrew Davis , Neha Malcom Francis , "Dasan, Nikhil" , "Menon, Nishanth" , "trini@konsulko.com" , "u-boot@lists.denx.de" , "Raghavendra, Vignesh" References: <20230419061352.3156023-1-u-kumar1@ti.com> <20230420081128.3617214-1-u-kumar1@ti.com> <217dded4-57ba-515f-dec9-77a63aebc303@ti.com> <77206a56-a0e9-ad4f-2c73-1f3b1109c649@ti.com> <92bbfb51-a605-27c9-9fd1-65a921532fdb@ti.com> <89918e21335c4fa18ae0d2447bea192b@ti.com> <4b016f2b-678a-43ff-bca0-9c2aee50eb02@ti.com> <1e92f584-6c59-6db4-ac59-4f6fe76c441e@ti.com> <29a1e2f6-36c5-42f6-5213-46a237ebf241@ti.com> Content-Language: en-US From: "Kumar, Udit" In-Reply-To: <29a1e2f6-36c5-42f6-5213-46a237ebf241@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/1/2023 8:16 PM, Andrew Davis wrote: > On 4/26/23 9:13 AM, Kumar, Udit wrote: >> Hi Neha, >> >> On 4/26/2023 5:31 PM, Neha Malcom Francis wrote: >>> Hi Udit >>> >>> On 26/04/23 16:09, Kumar, Udit wrote: >>>> Hi Neha, >>>> >>>>> Hi Udit, >>>> >>>> [..] >>>> >>>>>>> >>>>>>> I do have a general doubt; why do we have only atf-sram sub-node in >>>>>>> msmc_sram in all other devices (j721e, j7200 and am65) except >>>>>>> j721s2? >>>>>> >>>>>> let me know, which source code you are referring to >>>>>> >>>>> >>>>> In U-Boot, for j721e, j7200 and am65; they *only* contain atf-sram? >>>> >>>> For u-boot please see >>>> >>>> https://elixir.bootlin.com/u-boot/latest/source/arch/arm/dts/k3-j721s2-main.dtsi#L16 >>>> >>>> >>>>>> I could see for j721s2 as well, in uboot[0] and Linux[1] >>>> [..] >>>> >>> >>> What I mean to ask is, why aren't there tifs or l3cache subnodes in >>> j721e, j7200 and am65? >>> >> I think,  above platform is doing in right way, >> >> AFAIK,  if we have to provide then we can provide size of this. >> >> l3-cache can not be addressable. >> > > > So the history here is we used to have the SRAM node in DT sized > to the actual size in hardware. L3 cache size can be set at boot > time (in SYSFW board-config file), and that uses up some of the > SRAM, so the end address moves in. We could represent this as > a reserved node inside the full SRAM node, or by shrinking the > SRAM node and hiding this. Same story for TIFS and ATF, they > use some variable amount of the end of SRAM. > Ah, I have other view. We shrunk SRAM size already, having reserved node on top of SRAM is good as removing this. > I'd prefer being explicit and keep these nodes. > > Andrew > > >> But in any case, u-boot removes this code before passing to OS. >> >> https://elixir.bootlin.com/u-boot/latest/source/arch/arm/mach-k3/common.c#L354 >> >> >>>>> Thanking You >>>>> Neha Malcom Francis >>>