From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40C3DC7EE25 for ; Thu, 8 Jun 2023 18:46:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B032861CC; Thu, 8 Jun 2023 20:46:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="X/Eqsrd8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C25E85893; Thu, 8 Jun 2023 20:46:07 +0200 (CEST) Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3792E857D5 for ; Thu, 8 Jun 2023 20:46:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-77acb04309dso50653039f.2 for ; Thu, 08 Jun 2023 11:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686249961; x=1688841961; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ARQxteANpSm935KDgpy28cUHv1PLu5OAMZ5Vkm1o48E=; b=X/Eqsrd8D3QUUKarThTnYLOdePX0QeOArirv8sSQvHklZmET6AL1rzjHdLg3rbLPyQ /zy1d1M8uKc8QPOi2qeBPys3O7mKAZpe9L2YZO7xwWf5OPAfQsOTzaYpSjjLBoKJ2/tL V4imqzN3CqJ/hjUyFAqKEi/5mw3c9I4ONA2K/WGDnrXN1CqgUSMPYU2oPvO0XJMouK/H trWK6CXy+7u9FZhQ3knd98dIbZQHTEOkUvND2ean4JxfU4SG21fPiwMSWTC9nESCOcGu 8cknaWj6vx4lUymwk0fMQwU4vo5pYYajJU/g+74tC8MaTc7BBeaHHYSr/e+sJeChhtf3 jeXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686249961; x=1688841961; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ARQxteANpSm935KDgpy28cUHv1PLu5OAMZ5Vkm1o48E=; b=axga2kqKKCfr1vzTFuATsjKd3Ct/jceiG27a/sxGyrT7ZWZTvVb0DOmQy3UqqCsgoD RHtVxRbutM/o6OnWEAG2OtV31K7pjOynoNkkpib5RGxGWE4LWNfMoiPcwgcEyUCuF6VH Djj/tR38oqFB0aK69DbdROO6WPDUDVZpyqN7XMv468U3jGIe7YVJ2kkywR4amp+Sf8ld +y1p+cFieWkLE6U8kAFSa+QMtT+MrEY83jWRW37IbBkuuhonX1jHBt1FYRp59xdkMekU 4j2LutsymYKa32XUcTvyDObOogHgMMJ7zd83pt8Z6TdebgrfTatnAZDCaplir6EtD2mE kwgQ== X-Gm-Message-State: AC+VfDwxpJ6k0Z7E8D3bzN8oa28ZN5E1+s9cVX79B5T/0qE67mzWYHkZ 3Ng1My2cqdULcRxhqa4yq6kz2G/9/0Us7THu X-Google-Smtp-Source: ACHHUZ7H9ug6EYsARgR9t2wUDlzZEfd6enbOvRY21XauOIkG1/Y8WjE5ctrduUKvrM8uWexScECdcw== X-Received: by 2002:a6b:fc06:0:b0:777:ac19:f883 with SMTP id r6-20020a6bfc06000000b00777ac19f883mr12959382ioh.3.1686249960693; Thu, 08 Jun 2023 11:46:00 -0700 (PDT) Received: from ?IPV6:2001:470:42c4:101:48b2:a45a:f2d2:c155? ([2001:470:42c4:101:48b2:a45a:f2d2:c155]) by smtp.gmail.com with ESMTPSA id a22-20020a5d89d6000000b007747a6d875csm540127iot.9.2023.06.08.11.46.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jun 2023 11:46:00 -0700 (PDT) Message-ID: <61d95a47-2ae8-b0dc-7ccd-928d73dc2878@gmail.com> Date: Thu, 8 Jun 2023 12:45:59 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] usb: musb-new: sunxi: remove unused define Content-Language: en-US To: Marek Vasut , u-boot@lists.denx.de Cc: Andre Przywara , Jagan Teki References: <20230607231640.28162-1-CFSworks@gmail.com> <568980fb-fbda-d19f-e835-68c2ea2148bd@denx.de> From: Sam Edwards In-Reply-To: <568980fb-fbda-d19f-e835-68c2ea2148bd@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Marek, > Please add missing commit message and send V2. Ah, apologies! I had (mistakenly) believed that the summary line would be a sufficient commit message for something so trivial. Instead I did a little research into how this got here and wrote a quick explanation of why it's unused. I figure that would be a bit more helpful for someone reading the commit history than just reiterating that "It's, y'know, unused." :) > Otherwise > > Reviewed-by: Marek Vasut Thank you for the speedy review! Cheers, Sam