From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F2E5C4338F for ; Fri, 13 Aug 2021 06:17:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CA3A6109D for ; Fri, 13 Aug 2021 06:17:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2CA3A6109D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9561B82DCE; Fri, 13 Aug 2021 08:17:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628835457; bh=egXqOKNgZpyNZJF4y9zgX3DPUlPHIGMOhqoQmjzVbWw=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dHsgcZGH+KVqhwRgodXhWHsvrRm0olwo14Nl9aBHx99yWQDP1izr+RbJgh0+bylIC Pc14TJfJizh2Sy6/OAujvInUCARtPk6CKN+9KFIl+Y/ZyEMHG4IQ5N3jWSubhI8JLv R2Q2Fg8Ss3KsNllxMeOASVNYFI9MkehnKTCNCeLneYqZ63wGRu16532R1DhZfYlxkj 2J5vdYr7QhHZvg3nC1tRNzrH+MLK/U5DhexSYtLbzdqieXkX8R11NacGH1MZLmZDnE AfhuQCdoQuydDNYVaMispNrl69+JGrJALl3NvIx6HNsN4y7dKDf/gQjn6KF7vG7z6Y cPXTPqGEo0TYw== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 37CD582DA1 for ; Fri, 13 Aug 2021 08:17:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628835455; bh=egXqOKNgZpyNZJF4y9zgX3DPUlPHIGMOhqoQmjzVbWw=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=N52plcU8jOglqxkUnk9wsbZz7dBzFwZLaZdk9yrUU4z8HqDUO+YUNxejsOdLxxuPn cdK1qdRorALGHARfIAetpSy9jilBYMCEr7WWcPmhrFE9/yjxrZM3Wvv8tXTlpo/eww dVSKhY9qY22V1S5eW6ucw9NdgGP7OVxFgWtOQOp85DmbTylEzdttGTmfQU6M68N27x FNMXHKd2VYPdlgoACO4jhw/vFvCxiKUOU6DO415j6PfYKnOHfl4+gkqmbZf/CYqPex U9w4BS6WGZTKjl/VIdGtWMRpKdvCEq3aFzSAbxlVYm9RxQxA33eB4CzRH89Vmk1VOv hCeJoJqtj/sUg== Received: by janitor.denx.de (Postfix, from userid 108) id BFF89A014E; Fri, 13 Aug 2021 08:17:34 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id DE378A006C; Fri, 13 Aug 2021 08:17:24 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 9F3C51E2304; Fri, 13 Aug 2021 08:17:24 +0200 (CEST) To: Tom Rini cc: Rasmus Villemoes , Stefan Roese , u-boot@lists.denx.de, Simon Glass From: Wolfgang Denk Subject: Re: [PATCH v4 07/10] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset() MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20210812162034.GY858@bill-the-cat> References: <20210802150016.588750-8-rasmus.villemoes@prevas.dk> <024904e9-2205-37d9-e480-04de75c8cb5c@denx.de> <3d48015a-07d3-e296-b9ba-a1edd455ce9e@prevas.dk> <538195.1628684952@gemini.denx.de> <20210811124318.GT858@bill-the-cat> <575632.1628750421@gemini.denx.de> <20210812134833.GU858@bill-the-cat> <601067.1628778089@gemini.denx.de> <20210812162034.GY858@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Thu, 12 Aug 2021 12:20:34 -0400." Date: Fri, 13 Aug 2021 08:17:24 +0200 Message-ID: <631933.1628835444@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20210812162034.GY858@bill-the-cat> you wrote: > > > So if "the system is on fire" is one of the cases where an error > > message should be omitted to save maybe 50 or 100 bytes of image > > size? This sounds wrong to me. > > It sounds right to me because it's unlikely everything caught fire > because of this call right here and likely it's because of one of the > messages much further up on the console log. Hopefully we haven't > caused that message to be unavailable now due to unhelpful failure > messages. Omitting code to handle situations that are unlikely to happen is definitely not what I consider robust programming, and nothing which I would let pass a code review. But if you insist, there is no more to do for me here that to note that fact that we disagree. Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de People are very flexible and learn to adjust to strange surroundings -- they can become accustomed to read Lisp and Fortran programs, for example. - Leon Sterling and Ehud Shapiro, Art of Prolog, MIT Press