public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: u-boot@lists.denx.de
Subject: [PATCH v2] cmd: pxe: add support for FDT overlays
Date: Mon, 04 Jan 2021 17:21:45 +0100	[thread overview]
Message-ID: <6338426.mjuQUSspIG@jernej-laptop> (raw)
In-Reply-To: <20210104144117.GB2292@bill-the-cat>

Dne ponedeljek, 04. januar 2021 ob 15:41:17 CET je Tom Rini napisal(a):
> On Mon, Jan 04, 2021 at 03:33:43PM +0100, Neil Armstrong wrote:
> > This adds support for specifying FDT overlays in an extlinux/pxelinux
> > configuration file.
> > 
> > Without this, there is no simple way to apply overlays when the kernel
> > and fdt is loaded by the pxe command.
> > 
> > This change adds the 'fdtoverlays' keyword for a label, supporting
> > multiple
> > overlay files to be applied on top of the fdt specified in the 'fdt' or
> > 'devicetree' keyword.
> > 
> > Example:
> >   label linux
> >   
> >     kernel /Image
> >     devicetree /soc-board.dtb

This should be "fdt /soc-board.dtb",

> >     fdtoverlays /soc-board-function.dtbo
> >     append console=ttyS0,115200 root=/dev/mmcblk0p2 rootwait
> > 
> > This code makes usage of a new variable called fdtoverlay_addr_r used to
> > load the overlay files without overwritting anything important.
> > 
> > Cc: Tom Rini <trini@konsulko.com>
> > Cc: Andre Heider <a.heider@gmail.com>
> > Cc: Jernej ?krabec <jernej.skrabec@siol.net>
> > Cc: Jonas Karlman <jonas@kwiboo.se>
> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Tested-by: Jernej Skrabec <jernej.skrabec@siol.net>

With above fix:
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

> > ---
> > Hi Tom,
> > 
> > This is repost of my last year's attempt.
> > It fills a hole to allow loading FDT overlays using PXE/Extlinux without
> > using FIT.
> > 
> > V2 adds documentation.
> 
> Thanks for following up.  I assume this follows what the spec says for
> this file?

Which specs? Official extlinux configuration specs [1] don't say anything about 
device tree files, so anything related to that is an extension (I hope I found 
correct specs). I think this one is extremely useful, users can easily specify 
which overlay file(s) they want to be applied in a text file.

Best regards,
Jernej

[1] https://repo.or.cz/syslinux.git/blob/HEAD:/doc/syslinux.txt

  reply	other threads:[~2021-01-04 16:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 14:33 [PATCH v2] cmd: pxe: add support for FDT overlays Neil Armstrong
2021-01-04 14:41 ` Tom Rini
2021-01-04 16:21   ` Jernej Škrabec [this message]
2021-01-05  8:12     ` Neil Armstrong
2021-01-05  8:14     ` Neil Armstrong
2021-01-08 13:43       ` Tom Rini
2021-01-14 23:30       ` Tom Rini
2021-01-20  8:47         ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6338426.mjuQUSspIG@jernej-laptop \
    --to=jernej.skrabec@siol.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox