From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8421C432BE for ; Fri, 13 Aug 2021 06:54:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A411060FC4 for ; Fri, 13 Aug 2021 06:54:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A411060FC4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8401082D73; Fri, 13 Aug 2021 08:54:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628837675; bh=2wQbR1YwGwl5jjUuM+jj3e7Dd2QkdNKUfj511VOmXDw=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=iD8kZ5fiVthAjD6S/WVcQAFwoBbljRr0pw/JnAt7xQqaU71UxjwPZxMz1QYQILO1D 0mXbxMf5la3yh1dwX5caX/p2LZwMC1TXhz5p9vVEzj+S1Y2wp0pdGV3sZZNqDaC0H6 DdWbmrHEoFWQnOd/aypPq5hPxr1ic3uzrl8w8DUp26ExVuVj4dW3C+xwkklJiFHpM5 qYn10EJIPMwDPsReHtfdSDeSMwStbaFU1DSzP4ZPhzkW4ssiiP4DESng5J1KOqYmLt FmQrpeiuj9h6ka5aa/vyyi/CKK1CtU2As+guOWTV4abwunOTsk7b8OVJQuomrnMkoS XMdG+nOM1DCVg== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A7E1882DA1 for ; Fri, 13 Aug 2021 08:54:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1628837671; bh=2wQbR1YwGwl5jjUuM+jj3e7Dd2QkdNKUfj511VOmXDw=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=a1eP7rekfGC5aw8zFHfhqiKUEsQNnKlpDy4Kpl7tBemsep3BShmShZfBHdcjwRpZF nswV140N9tdna3Fa3wyETL3Q8Y3tnZigD6mNzIv30Uw4uPDDigTlpJ+BNW5kKwGyBi +wn1WKXI4nq2vpIZGwfS8R2j6qAZ7fb1I1Ip5cuJpRCpM768YLKBYt7ynoPCxuHGjB /LbdKh38EVOts9mKHbiQvt/qL5BsgkhoHcSEPFkNQKTie8EmKW3Jkic0tDrnOyHLhq i1uU0pwRK1KdRHxosJ3XwtcLTZ5A6EjZYVVUSsYp+FyLbpcl3GJ+R0eoKPBfpVk7FH yvVwmNZYk5AGg== Received: by janitor.denx.de (Postfix, from userid 108) id 4A2F7A014E; Fri, 13 Aug 2021 08:54:31 +0200 (CEST) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 9C1D2A006C; Fri, 13 Aug 2021 08:54:20 +0200 (CEST) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 55BAC1E2304; Fri, 13 Aug 2021 08:54:20 +0200 (CEST) To: Michal Simek cc: u-boot@lists.denx.de, git@xilinx.com, Igor Opaniuk , Simon Glass From: Wolfgang Denk Subject: Re: [PATCH] cmd: boot: Update reset usage message MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <90e6c670-9e11-beb8-bcb5-9d22ba00fd11@xilinx.com> References: <82e0d7efdbd9f8c62f46c7e1a8913ffa52de5a1e.1628676265.git.michal.simek@xilinx.com> <631616.1628835089@gemini.denx.de> <90e6c670-9e11-beb8-bcb5-9d22ba00fd11@xilinx.com> Comments: In-reply-to Michal Simek message dated "Fri, 13 Aug 2021 08:30:17 +0200." Date: Fri, 13 Aug 2021 08:54:20 +0200 Message-ID: <634088.1628837660@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Michal, In message <90e6c670-9e11-beb8-bcb5-9d22ba00fd11@xilinx.com> you wrote: > > > In case of the hard (cold) reset - is it really only a reset of the > > CPU, or of the whole board hardware? > > If you look at sysreset headers you will find these levels > 11 SYSRESET_WARM, /* Reset CPU, keep GPIOs active */ > 12 SYSRESET_COLD, /* Reset CPU and GPIOs */ > 13 SYSRESET_POWER, /* Reset PMIC (remove and restore power) */ > 14 SYSRESET_POWER_OFF, /* Turn off power */ > > When you call reset sysreset uclass is calling sysreset_walk which is > request to drivers with type passed. > I see we have mixed drivers which deals with levels and especially in > gpio case it is question how you connect it. > I develop this for microblaze where gpio is connected reset logic which > is normally only for CPU and subsystem. > But in general you can connect whatever you want. It means it doesn't > need to be only cpu which is reset. Thanks a lot for the explanation. > Do you want me to update that line and remove CPU from it? I don't know :-) What the "reset" command _should_ do is a hard cold boot including the reset of all peripherals - for example, when booting from SPI NOR flash it is mandatory to reset this flash to make sure the ROM boot loader can actually read it. I would appreciate if the help message documents what it actually does. Also, what the difference between "cold" and "warm" reset is. My expectation (without knowing any hardware details) would be that a warm reset is just a restart of the already loaded code? Or is it just a reset of the CPU (without external reset)? This might then hang the system if it's attempting to boot from a flash which is in the wrong state. So my problem with this is primarily that I don't understand what the command really does, and the help command is of no help either. [And if I understand correctly, this is even board dependent?] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de How many NASA managers does it take to screw in a lightbulb? "That's a known problem... don't worry about it."