public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Jonathan Humphreys <j-humphreys@ti.com>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Martyn Welch <martyn.welch@collabora.com>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Sjoerd Simons <sjoerd@collabora.com>,
	Tom Rini <trini@konsulko.com>,
	vigneshr@ti.com
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] configs: am62x_evm_*: Set DFU buffer size to 256k
Date: Sat, 4 Jan 2025 19:05:37 +0200	[thread overview]
Message-ID: <63829810-b338-4e5f-aa48-ad371f60d01f@kernel.org> (raw)
In-Reply-To: <20241220215334.372542-1-j-humphreys@ti.com>



On 20/12/2024 23:53, Jonathan Humphreys wrote:
> OSPI flash writing was broken on am62x SKs as the OSPI flash device has a
> 256k sector size but was set to 20k. This breaks OSPI flash writes because
> the current implementation of the SF DFU backend requires that the DFU data
> buffer size be the same as the sector erase size, and the USB DFU config
> fragment (for both A53 and R5) reduced the size of the DFU data buffer,
> presumably so that it can fit into SPL's much smaller heap.
> 
> Change the SYS_DFU_DATA_BUF_SIZE to the erase sector size, which still fits
> within the post-relocation heap size in SPL.
> 
> Fixes: dfc2dff5a844 ("configs: am62x_evm_*: Enable USB and DFU support")
> 
> Signed-off-by: Jonathan Humphreys <j-humphreys@ti.com>

Reviewed-by: Roger Quadros <rogerq@kernel.org>


  reply	other threads:[~2025-01-04 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 21:53 [PATCH] configs: am62x_evm_*: Set DFU buffer size to 256k Jonathan Humphreys
2025-01-04 17:05 ` Roger Quadros [this message]
2025-01-16  8:38 ` Mattijs Korpershoek
2025-01-21 17:34 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63829810-b338-4e5f-aa48-ad371f60d01f@kernel.org \
    --to=rogerq@kernel.org \
    --cc=j-humphreys@ti.com \
    --cc=martyn.welch@collabora.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=s-vadapalli@ti.com \
    --cc=sjoerd@collabora.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox