From: Alper Nebi Yasak <alpernebiyasak@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 3/3] binman: Allow resolving host-specific tools from env vars
Date: Sun, 6 Sep 2020 02:16:06 +0300 [thread overview]
Message-ID: <63ebdc77-bf4a-8f34-a859-bfb97ec8f5e1@gmail.com> (raw)
In-Reply-To: <CAPnjgZ3Oy3augxTVAFN6gHO05C9xw16AkKfknLjSUJQZLik=ig@mail.gmail.com>
On 05/09/2020 19:37, Simon Glass wrote:
> Please see below.
>
> Also please add a mention of the CROSS_COMPILE thing in binman's README.
>
>> +def GetHostCompileTool(name):
>> + """Get the host-specific version for a compile tool
>> +
>> + This checks the environment variables that specify which version of
>> + the tool should be used.
>
> Can you please expand the comment to mention the environment variables
> it checks?
OK, will send a v2 after doing these with the fixes for the first patch
(unless you point out until then something new that I should fix).
prev parent reply other threads:[~2020-09-05 23:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 14:43 [PATCH 0/3] binman: Make tests work on non-x86 architectures via cross-compilation Alper Nebi Yasak
2020-09-05 14:43 ` [PATCH 1/3] binman: Support cross-compiling test files to x86 Alper Nebi Yasak
2020-09-05 16:36 ` Simon Glass
2020-09-05 22:51 ` Alper Nebi Yasak
2020-09-06 0:17 ` Simon Glass
2020-09-05 14:43 ` [PATCH 2/3] binman: Use target-specific tools when cross-compiling Alper Nebi Yasak
2020-09-05 16:37 ` Simon Glass
2020-09-05 23:04 ` Alper Nebi Yasak
2020-09-06 0:17 ` Simon Glass
2020-09-05 14:43 ` [PATCH 3/3] binman: Allow resolving host-specific tools from env vars Alper Nebi Yasak
2020-09-05 16:37 ` Simon Glass
2020-09-05 23:16 ` Alper Nebi Yasak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63ebdc77-bf4a-8f34-a859-bfb97ec8f5e1@gmail.com \
--to=alpernebiyasak@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox