public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ron Madrid <ron_madrid@sbcglobal.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc83xx: fix undefined reference to `flush_cache' error in simpc8313 build
Date: Wed, 28 Jan 2009 14:59:25 -0800 (PST)	[thread overview]
Message-ID: <644263.23560.qm@web83508.mail.sp1.yahoo.com> (raw)
In-Reply-To: <4980DB7E.1060104@freescale.com>

--- On Wed, 1/28/09, Scott Wood <scottwood@freescale.com> wrote:

> From: Scott Wood <scottwood@freescale.com>
> Subject: Re: [U-Boot] [PATCH] mpc83xx: fix undefined reference to `flush_cache' error in simpc8313 build
> To: ron_madrid at sbcglobal.net
> Cc: "Wolfgang Denk" <wd@denx.de>, u-boot at lists.denx.de, "Kim Phillips" <kim.phillips@freescale.com>
> Date: Wednesday, January 28, 2009, 2:26 PM
> Ron Madrid wrote:
> > It would seem that the drivers/serial/ns16550.c file
> currently being
> > included in my project has a few functions that are
> completely unused
> > by my board.  Is it allowable to duplicate the two
> functions I do use
> > (NS16550_putc and NS16550_init) in my code within a
> #ifdef CONFIG_NAND_SPL? This saves about 120 (decimal) bytes
> in the bootstrap image.
> 
> Maybe just put #ifndef CONFIG_NAND_SPL in the existing
> file?  I'm assuming that none of the other boards are
> going to need anything other than init and putc in their
> NAND loaders.

It would appear that within the nand_spl directory the mpc8313erdb and the
simpc8313 are the only two board that include the file ns16550.c in the
build.  These changes work for my board (with the patch that Kim sent out
earlier) and at this time I am running the MAKEALL.  After that succeeds I
will send the patch.

Ron
> 
> -Scott

      reply	other threads:[~2009-01-28 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 22:03 [U-Boot] [PATCH] mpc83xx: fix undefined reference to `flush_cache' error in simpc8313 build Kim Phillips
2009-01-28  9:01 ` Wolfgang Denk
2009-01-28 18:45   ` Ron Madrid
2009-01-28 19:18     ` Wolfgang Denk
2009-01-28 19:21       ` Ron Madrid
2009-01-28 20:24       ` Scott Wood
2009-01-28 22:24         ` Ron Madrid
2009-01-28 22:26           ` Scott Wood
2009-01-28 22:59             ` Ron Madrid [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=644263.23560.qm@web83508.mail.sp1.yahoo.com \
    --to=ron_madrid@sbcglobal.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox