From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E52EFC77B78 for ; Tue, 2 May 2023 19:22:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2BB3684746; Tue, 2 May 2023 21:21:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PEnWx9kf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD5DA846EA; Tue, 2 May 2023 20:41:03 +0200 (CEST) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 12EF4846DF for ; Tue, 2 May 2023 20:41:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prusovigor@gmail.com Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2a8ba23a2abso41739081fa.2 for ; Tue, 02 May 2023 11:41:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683052859; x=1685644859; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=188Dznl0ifUtV3we9ngqxolwbM8m32x80p7aogDia14=; b=PEnWx9kf8aVom35qISYV1RCfqUaqaxLArRSvB192CnsMgM6c+GzMoSHBWlMC6nRvRd BUstsmkIcwQ61BxusHL59NTYrfORXjKM0IZOpBXvncPhDrnO30Tw7XTtJKKEAUTUFLVe ZHYNWiswaUwqvL8tCuxWM42nyry3FqFToCbZ5aSmoNW6KCE9mttQP3pGjbYEI7lfU/fV u9aU0ZvxcsILQdMuCFUFlRg78FjUyA4D7xogK8sVOaCsX3sugYKbnff+c1jmh4JthBub fr67aVtaRZE15oxkQEwTSc9x/+AhHgCzgr5N0U2412m7Ca8DoF/r9YIZCJ/T63a5dHoe 07tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683052859; x=1685644859; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=188Dznl0ifUtV3we9ngqxolwbM8m32x80p7aogDia14=; b=RVGNoxFtTN3Ye7ItWjiVsPFIOipqoaEUZUXRWmYfE0UZXX1WTybpjUWilolIN1LC7A +m98rQ8CYuWsi+voMKrticbWAfXBoWoZPGdH+6Lt/uSjR088NIba461N4kytR7xNhc5W ws69znGFkPo1earnuxnh95BZz3CmmdqxKc5vs3TB0d6d5GJXoBVjm3N+LCwOP7PrPuPh Uea7t+2cfUnfBbrmKdjmKVuMvccWsgI3wTJ0Xm3JtHIFnsbaWDS70FTzm5U9oDN04581 gVluD99Zfcr12niq6Q2AFi90gUc9fvaYiIWQpIYtdNAvTNS8COvJ+rmPUAFPIELe+CNo WQgw== X-Gm-Message-State: AC+VfDzQURUk95GNCAtqjgwvorCBqErlGTSw/xZXiz3Q+3yvCU26FF6c BX/8ld1U6v4+gMir8/RU39I= X-Google-Smtp-Source: ACHHUZ7RBjxFVrO7r54DMhtIG+HZtcPRkB7w/I9pg9gG270lBn/oc1mZXAx3hxJ3J0N9oUW1yJB6AQ== X-Received: by 2002:ac2:5199:0:b0:4eb:2643:c6c6 with SMTP id u25-20020ac25199000000b004eb2643c6c6mr220009lfi.53.1683052859148; Tue, 02 May 2023 11:40:59 -0700 (PDT) Received: from DESKTOP-G0QQV4M. ([83.217.200.249]) by smtp.gmail.com with ESMTPSA id l14-20020ac2554e000000b004dda76fad5asm5493722lfk.218.2023.05.02.11.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 May 2023 11:40:58 -0700 (PDT) Message-ID: <6451593a.c20a0220.2fb7d.0870@mx.google.com> X-Google-Original-Message-ID: <20230502184056.xjjo3m5mytllq224@DESKTOP-G0QQV4M.> Date: Tue, 2 May 2023 21:40:56 +0300 From: Igor Prusov To: Michal Simek Cc: Igor Prusov , Daniel Schwierzeck , Lukasz Majewski , Sean Anderson , Ryan Chen , Chia-Wei Wang , Aspeed BMC SW team , Joel Stanley , Stefan Roese , Patrick Delaunay , Patrice Chotard , kernel@sberdevices.ru, u-boot@lists.denx.de, uboot-stm32@st-md-mailman.stormreply.com Subject: Re: [RFC PATCH v1 6/7] clk: treewide: switch to clock dump from clk_ops References: <20230427203726.11835-1-ivprusov@sberdevices.ru> <20230427203726.11835-7-ivprusov@sberdevices.ru> <6b4101b8-c047-b8aa-e54b-e8eee03fa2fc@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b4101b8-c047-b8aa-e54b-e8eee03fa2fc@amd.com> X-Mailman-Approved-At: Tue, 02 May 2023 21:21:13 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hello Michal, On Tue, May 02, 2023 at 04:02:00PM +0200, Michal Simek wrote: > > > On 4/27/23 22:37, Igor Prusov wrote: > > Switch to using new dump operation in clock provider drivers instead of > > overriding soc_clk_dump. > > > > Signed-off-by: Igor Prusov > > --- > > arch/mips/mach-pic32/cpu.c | 23 --------------- > > drivers/clk/aspeed/clk_ast2600.c | 13 ++++----- > > drivers/clk/clk_k210.c | 11 +++----- > > drivers/clk/clk_pic32.c | 39 ++++++++++++++++++++++++++ > > drivers/clk/clk_versal.c | 7 ++++- > > drivers/clk/clk_zynq.c | 19 ++++--------- > > drivers/clk/clk_zynqmp.c | 13 ++++----- > > drivers/clk/imx/clk-imx8.c | 11 +++----- > > drivers/clk/mvebu/armada-37xx-periph.c | 5 +++- > > drivers/clk/stm32/clk-stm32mp1.c | 29 ++++++------------- > > 10 files changed, 83 insertions(+), 87 deletions(-) > > > > diff --git a/arch/mips/mach-pic32/cpu.c b/arch/mips/mach-pic32/cpu.c > > index de449e3c6a..2875a1ec7c 100644 > > --- a/arch/mips/mach-pic32/cpu.c > > +++ b/arch/mips/mach-pic32/cpu.c > > @@ -148,26 +148,3 @@ const char *get_core_name(void) > > return str; > > } > > #endif > > -#ifdef CONFIG_CMD_CLK > > - > > -int soc_clk_dump(void) > > -{ > > - int i; > > - > > - printf("PLL Speed: %lu MHz\n", > > - CLK_MHZ(rate(PLLCLK))); > > - > > - printf("CPU Speed: %lu MHz\n", CLK_MHZ(rate(PB7CLK))); > > - > > - printf("MPLL Speed: %lu MHz\n", CLK_MHZ(rate(MPLL))); > > - > > - for (i = PB1CLK; i <= PB7CLK; i++) > > - printf("PB%d Clock Speed: %lu MHz\n", i - PB1CLK + 1, > > - CLK_MHZ(rate(i))); > > - > > - for (i = REF1CLK; i <= REF5CLK; i++) > > - printf("REFO%d Clock Speed: %lu MHz\n", i - REF1CLK + 1, > > - CLK_MHZ(rate(i))); > > - return 0; > > -} > > -#endif > > diff --git a/drivers/clk/aspeed/clk_ast2600.c b/drivers/clk/aspeed/clk_ast2600.c > > index b3cc8392fa..08db21d394 100644 > > --- a/drivers/clk/aspeed/clk_ast2600.c > > +++ b/drivers/clk/aspeed/clk_ast2600.c > > @@ -1109,6 +1109,7 @@ struct aspeed_clks { > > const char *name; > > }; > > +#if IS_ENABLED(CONFIG_CMD_CLK) > > static struct aspeed_clks aspeed_clk_names[] = { > > { ASPEED_CLK_HPLL, "hpll" }, > > { ASPEED_CLK_MPLL, "mpll" }, > > @@ -1123,18 +1124,12 @@ static struct aspeed_clks aspeed_clk_names[] = { > > { ASPEED_CLK_HUARTX, "huxclk" }, > > }; > > -int soc_clk_dump(void) > > +int ast2600_clk_dump(struct udevice *dev) > > static? apply for all below too. Indeed, will fix in v2, thanks! > > M -- Best Regards, Igor Prusov