From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex G. Date: Wed, 21 Apr 2021 14:30:20 -0500 Subject: [PATCH v4 2/6] lib: ecdsa: Add skeleton to implement ecdsa verification in u-boot In-Reply-To: References: <20210415200509.2335046-1-mr.nuke.me@gmail.com> <20210415200509.2335046-3-mr.nuke.me@gmail.com> Message-ID: <653e2e0c-f4b6-f4ea-e5c8-d978817f7aba@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/21/21 2:15 AM, Simon Glass wrote: > Hi Alexandru, > > On Fri, 16 Apr 2021 at 08:07, Alexandru Gagniuc wrote: >> >> Prepare the source tree for accepting implementations of the ECDSA >> algorithm. This patch deals with the boring aspects of Makefiles and >> Kconfig files. >> >> Signed-off-by: Alexandru Gagniuc >> --- >> include/image.h | 10 +++++----- >> include/u-boot/rsa.h | 2 +- >> lib/Kconfig | 1 + >> lib/Makefile | 1 + >> lib/ecdsa/Kconfig | 23 +++++++++++++++++++++++ >> lib/ecdsa/Makefile | 1 + >> lib/ecdsa/ecdsa-verify.c | 13 +++++++++++++ >> 7 files changed, 45 insertions(+), 6 deletions(-) >> create mode 100644 lib/ecdsa/Kconfig >> create mode 100644 lib/ecdsa/Makefile >> create mode 100644 lib/ecdsa/ecdsa-verify.c > > Reviewed-by: Simon Glass > > nit below > >> >> diff --git a/include/image.h b/include/image.h >> index 3ff3c035a7..9b95f6783b 100644 >> --- a/include/image.h >> +++ b/include/image.h >> @@ -1224,20 +1224,20 @@ int calculate_hash(const void *data, int data_len, const char *algo, >> #if defined(USE_HOSTCC) >> # if defined(CONFIG_FIT_SIGNATURE) >> # define IMAGE_ENABLE_SIGN 1 >> -# define IMAGE_ENABLE_VERIFY 1 >> +# define IMAGE_ENABLE_VERIFY_RSA 1 >> # define IMAGE_ENABLE_VERIFY_ECDSA 1 >> # define FIT_IMAGE_ENABLE_VERIFY 1 >> # include >> # else >> # define IMAGE_ENABLE_SIGN 0 >> -# define IMAGE_ENABLE_VERIFY 0 >> +# define IMAGE_ENABLE_VERIFY_RSA 0 >> # define IMAGE_ENABLE_VERIFY_ECDSA 0 >> # define FIT_IMAGE_ENABLE_VERIFY 0 >> # endif >> #else >> # define IMAGE_ENABLE_SIGN 0 >> -# define IMAGE_ENABLE_VERIFY CONFIG_IS_ENABLED(RSA_VERIFY) >> -# define IMAGE_ENABLE_VERIFY_ECDSA 0 >> +# define IMAGE_ENABLE_VERIFY_RSA CONFIG_IS_ENABLED(RSA_VERIFY) >> +# define IMAGE_ENABLE_VERIFY_ECDSA CONFIG_IS_ENABLED(ECDSA_VERIFY) > > Since we are using Kconfig now, can we drop this IMAGE_... stuff and > just use CONFIG_IS_ENABLED() in the code? CONFIG_IS_ENABLED() doesn't work for host tools. Alex