U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rogerio Guerra Borin <rogerio.borin@toradex.com>
To: Quentin Schulz <quentin.schulz@cherry.de>,
	Rogerio Guerra Borin <rogerio.borin@gmail.com>,
	Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] cmd: fuse: add switch for quiet operation
Date: Sun, 30 Mar 2025 16:37:00 -0300	[thread overview]
Message-ID: <6570a5ff-ad3d-4371-99db-ae665af4ee16@toradex.com> (raw)
In-Reply-To: <c45358f6-e84f-4fc6-b5ae-44a3ff5985f1@cherry.de>

Hello Quentin,

Thanks for you feedback.

On 3/24/25 06:55, Quentin Schulz wrote:
> I think this is a reasonable expectation. I'm wondering if we shouldn't 
> think about using the log architecture we have to have a generic 
> solution rather than expecting each command driver to handle (possibly 
> in their own way) a quiet flag.
> 
> https://docs.u-boot.org/en/latest/develop/logging.html
> 
> The idea I have in mind is that we could dynamically set the loglevel 
> for a specific command driver (or at least for the command subsystem (by 
> e.g. defining an LOG_CATEGORY LOGC_CMD) and use log_* functions in the 
> command driver rather than IF_NOT_QUIET() below. This would also allow 
> different log levels to be used. Maybe there's something to be done with 
> filters, or something new needs to be added to set the log level for a 
> category maybe? I don't know, not too verse in our log system.
> 
> Another option to have a generic logic would be to depend on an 
> environment variable instead of needing to expand each command driver's 
> logic.

That's a great idea. I'll look into it and get back when I have something.

Regards,
Rogerio


  reply	other threads:[~2025-03-31  2:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-17 22:53 [PATCH] cmd: fuse: add switch for quiet operation Rogerio Guerra Borin
2025-03-24  9:55 ` Quentin Schulz
2025-03-30 19:37   ` Rogerio Guerra Borin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-03-14 19:54 Rogerio Guerra Borin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6570a5ff-ad3d-4371-99db-ae665af4ee16@toradex.com \
    --to=rogerio.borin@toradex.com \
    --cc=quentin.schulz@cherry.de \
    --cc=rogerio.borin@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox