From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Anderson <seanga2@gmail.com>
Date: Fri, 7 Aug 2020 10:55:28 -0400
Subject: [PATCH v2 01/10] spi: dw: Convert calls to debug to log_*
In-Reply-To: <6f5c478a-6271-1d68-66ee-bcc674570431@denx.de>
References: <20200807144317.282868-1-seanga2@gmail.com>
 <20200807144317.282868-2-seanga2@gmail.com>
 <6f5c478a-6271-1d68-66ee-bcc674570431@denx.de>
Message-ID: <663cd9f4-03e4-55bd-8b6f-5e17c43d660d@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


On 8/7/20 10:49 AM, Marek Vasut wrote:
> On 8/7/20 4:43 PM, Sean Anderson wrote:
> [...]
>> +#define LOG_CATEGORY UCLASS_SPI
>>  #include <common.h>
>>  #include <log.h>
>>  #include <asm-generic/gpio.h>
>> @@ -139,7 +140,7 @@ static int request_gpio_cs(struct udevice *bus)
>>  		return 0;
>>  
>>  	if (ret < 0) {
>> -		printf("Error: %d: Can't get %s gpio!\n", ret, bus->name);
>> +		log_err("Error: %d: Can't get %s gpio!\n", ret, bus->name);
> 
> Can't we use dev_info() / pr_info() , same as the linux kernel does ?
> 

We can. It doesn't matter much to me. Simon, does U-Boot prefer a
particular log style for new code?

--Sean