From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Mon, 26 Oct 2020 10:19:32 +0100 Subject: [PATCH v2 1/8] Revert "mmc: zynq: parse dt when probing" In-Reply-To: <3f6b5f7c-dc8d-c34e-baa8-bc6ecf77c9c6@samsung.com> References: <4e0ad8429b295a1ecc072c8272c9145fd497b31a.1603451681.git.michal.simek@xilinx.com> <3f6b5f7c-dc8d-c34e-baa8-bc6ecf77c9c6@samsung.com> Message-ID: <66f981f9-4e1f-d646-176c-ece82cd5b8f9@xilinx.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 26. 10. 20 8:22, Jaehoon Chung wrote: > On 10/23/20 8:14 PM, Michal Simek wrote: >> From: Ashok Reddy Soma >> >> This reverts commit 942b5fc03218d1c94468fc658e7dec65dabcc830. >> >> This is partial revert of the above commit. >> >> mmc_of_parse() is reading no-1-8-v from device tree and if set, >> it is clearing the UHS speed capabilities of cfg->host_caps. >> cfg->host_caps &= ~(UHS_CAPS | MMC_MODE_HS200 | >> MMC_MODE_HS400 | MMC_MODE_HS400_ES); >> >> This is still missing to clear UHS speeds like SDHCI_SUPPORT_SDR104, >> SDHCI_SUPPORT_SDR50 and SDHCI_SUPPORT_DDR50. >> >> Even if we clear the flags SDHCI_SUPPORT_XXX in mmc_of_parse(), >> these speed flags are getting set again in cfg->host_caps in >> sdhci_setup_cfg(). >> >> The reason for this is, SDHCI_SUPPORT_XXX flags are cleared >> only if controller is not capable of supporting MMC_VDD_165_195 volts. >> >> if (caps & SDHCI_CAN_VDD_180) >> cfg->voltages |= MMC_VDD_165_195; >> >> if (!(cfg->voltages & MMC_VDD_165_195)) >> caps_1 &= ~(SDHCI_SUPPORT_SDR104 | SDHCI_SUPPORT_SDR50 | >> SDHCI_SUPPORT_DDR50); >> >> It means "no-1-8-v", which is read from DT is not coming in to effect. >> So it is better we keep the host quirks(SDHCI_QUIRK_NO_1_8_V) to >> clear UHS speeds based on no-1-8-v from device tree. >> >> Hence revert the functionality related to no-1-8-v only, rest is fine >> in the patch. >> >> Signed-off-by: Ashok Reddy Soma >> Signed-off-by: Michal Simek > > Reviewed-by: Jaehoon Chung Any comment for the rest of patches? Thanks, Michal