Re: [PATCH v5 03/11] led: implement LED boot API

Simon Glass
2024-10-03T21:30:53Z

Hi Christian,

On Wed, 2 Oct 2024 at 17:00, Christian Marangi <ansuelsmth@gmail.com> wrote:
>
> On Wed, Oct 02, 2024 at 04:55:42PM -0600, Simon Glass wrote:
> > On Tue, 1 Oct 2024 at 06:25, Christian Marangi <ansuelsmth@gmail.com> wrote:
> > >
> > > Implement LED boot API to signal correct boot of the system.
> > >
> > > led_boot_on/off/blink() are introduced to turn ON, OFF and BLINK the
> > > designated boot LED.
> > >
> > > New Kconfig is introduced, CONFIG_LED_BOOT to enable the feature.
> > > This makes use of the /options/u-boot property "boot-led" to the
> > > define the boot LED.
> > > It's also introduced a new /options/u-boot property "boot-led-period"
> > > to define the default period when the LED is set to blink mode.
> >
> > BTW could you please send a schema update for this so that Linux accepts it?
> >
>
> I open a PR there [1] or should I use other way?
>
> [1] https://github.com/devicetree-org/dt-schema/pull/144

Well I see others getting merged, so yes that seems to be fine. I have
only ever used the mailing list myself.

Regards,
SImon

>
> > >
> > > If "boot-led-period" is not defined, the value of 250 (ms) is
> > > used by default.
> > >
> > > If CONFIG_LED_BLINK or CONFIG_LED_SW_BLINK is not enabled,
> > > led_boot_blink call will fallback to simple LED ON.
> > >
> > > To cache the data we repurpose the now unused led_uc_priv for storage of
> > > global LED uclass info.
> > >
> > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > > ---
> > > drivers/led/Kconfig | 11 ++++++
> > > drivers/led/led-uclass.c | 85 ++++++++++++++++++++++++++++++++++++++++
> > > include/led.h | 55 +++++++++++++++++++++++++-
> > > 3 files changed, 149 insertions(+), 2 deletions(-)
> > >
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
>
> --
> Ansuel