Re: [PATCH v5 01/11] led: toggle LED on initial SW blink

Christian Marangi
2024-10-03T04:41:39Z

On Wed, Oct 02, 2024 at 04:55:41PM -0600, Simon Glass wrote:
> On Tue, 1 Oct 2024 at 06:25, Christian Marangi <ansuelsmth@gmail.com> wrote:
> >
> > We currently init the LED OFF when SW blink is triggered when
> > on_state_change() is called. This can be problematic for very short
> > period as the ON/OFF blink might never trigger.
> >
> > Toggle the LED (ON if OFF, OFF if ON) on initial SW blink to handle this
> > corner case and better display a LED blink from the user.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > drivers/led/led_sw_blink.c | 17 +++++++++++++++--
> > 1 file changed, 15 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Running a little bit blind here without a changelog. If you use patman
> it will do this automatically.

The cover letter didn't slip in the mailing list? Changelog is there or
I'm missing something?

--
Ansuel