[U-Boot] [PATCH 4/5] arm: ensure u-boot only uses relative relocations

Benoît Thébaudeau
2013-05-14T22:12:24Z

Hi Albert,

On Tuesday, May 14, 2013 10:02:59 PM, Albert ARIBAUD wrote:
> Add a Makefile target ('checkarmreloc') which
> fails of the ELF binary contains relocation records
> of types other than R_ARM_RELATIVE.
>
> Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> Makefile | 7 +++++++
> arch/arm/config.mk | 5 +++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c52f0f1..9aa5755 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -746,6 +746,13 @@ tools: $(VERSION_FILE) $(TIMESTAMP_FILE)
> $(MAKE) -C $@ all
> endif # config.mk
>
> +# ARM relocations should all be R_ARM_RELATIVE.
> +checkarmreloc: $(obj)u-boot
> + @if test "R_ARM_RELATIVE" != \
> + "`readelf -r $(obj)u-boot | cut -d ' ' -f 4 | grep R_ARM | sort -u`"; \
^
or $$< to avoid a duplicate?

> + then echo "$(obj)u-boot contains relocations other than \
^
or $$< too, or no $(obj) prefix@all for this message?

> + R_ARM_RELATIVE"; false; fi
> +
> $(VERSION_FILE):
> @mkdir -p $(dir $(VERSION_FILE))
> @( localvers='$(shell $(TOPDIR)/tools/setlocalversion $(TOPDIR))' ; \
> diff --git a/arch/arm/config.mk b/arch/arm/config.mk
> index 461899e..5b7a602 100644
> --- a/arch/arm/config.mk
> +++ b/arch/arm/config.mk
> @@ -106,3 +106,8 @@ ifeq ($(GAS_BUG_12532),y)
> PLATFORM_RELFLAGS += -fno-optimize-sibling-calls
> endif
> endif
> +
> +# check that only R_ARM_RELATIVE relocations are generated
> +ifneq ($(CONFIG_SPL_BUILD),y)
> +ALL-y += checkarmreloc
> +endif
> --
> 1.7.10.4

Best regards,
Beno?t