From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] mx25: Define cpu_eth_init() only if needed
Date: Thu, 27 Sep 2012 23:43:12 +0200 (CEST) [thread overview]
Message-ID: <678974406.5374837.1348782192487.JavaMail.root@advansee.com> (raw)
In-Reply-To: <CAOMZO5A4ugHYA5HPA+qhiKcGb6n6AdFnHe+sYEMw=rWwAVOxoQ@mail.gmail.com>
Hi Fabio,
On Thursday, September 27, 2012 10:55:22 PM, Fabio Estevam wrote:
> Hi Beno?t,
>
> On Thu, Sep 27, 2012 at 5:28 PM, Beno?t Th?baudeau
> <benoit.thebaudeau@advansee.com> wrote:
> > The FEC is the only SoC Ethernet support available on i.MX25, so
> > define
> > cpu_eth_init() only for it instead of returning a misleading
> > success code.
>
> Yes, but someone may want to use mx25 with a external LAN device
> (such
> as LAN92xx) instead of FEC.
Yes, but in that case I think that there should be a board_eth_init() function
defined, so this patch won't cause any trouble here. See in
net/eth.c:eth_initialize() how these functions and their default implementations
are handled.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-09-27 21:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 20:26 [U-Boot] [PATCH 1/7] mx25: Fix decode_pll Benoît Thébaudeau
2012-09-27 20:27 ` [U-Boot] [PATCH 2/7] mx25: Clean up clock calculations Benoît Thébaudeau
2012-09-27 20:27 ` [U-Boot] [PATCH 3/7] mx25: Define more standard clocks Benoît Thébaudeau
2012-09-27 20:27 ` [U-Boot] [PATCH 4/7] mx25 clocks: Fix MXC_FEC_CLK Benoît Thébaudeau
2012-09-28 10:33 ` Stefano Babic
2012-09-27 20:27 ` [U-Boot] [PATCH 5/7] mx25: Clean up clocks API Benoît Thébaudeau
2012-09-28 10:31 ` Stefano Babic
2012-09-27 20:28 ` [U-Boot] [PATCH 6/7] mx25: Define cpu_eth_init() only if needed Benoît Thébaudeau
2012-09-27 20:55 ` Fabio Estevam
2012-09-27 21:43 ` Benoît Thébaudeau [this message]
2012-09-28 9:09 ` Stefano Babic
2012-09-27 20:28 ` [U-Boot] [PATCH 7/7] mx25: Fix eSDHC support Benoît Thébaudeau
2012-09-30 10:26 ` [U-Boot] [PATCH 1/7] mx25: Fix decode_pll Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=678974406.5374837.1348782192487.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox