[U-Boot] [PATCH 6/7] mx25: Define cpu_eth_init() only if needed

Benoît Thébaudeau
2012-09-27T21:43:12Z

Hi Fabio,

On Thursday, September 27, 2012 10:55:22 PM, Fabio Estevam wrote:
> Hi Beno?t,
>
> On Thu, Sep 27, 2012 at 5:28 PM, Beno?t Th?baudeau
> <benoit.thebaudeau@advansee.com> wrote:
> > The FEC is the only SoC Ethernet support available on i.MX25, so
> > define
> > cpu_eth_init() only for it instead of returning a misleading
> > success code.
>
> Yes, but someone may want to use mx25 with a external LAN device
> (such
> as LAN92xx) instead of FEC.

Yes, but in that case I think that there should be a board_eth_init() function
defined, so this patch won't cause any trouble here. See in
net/eth.c:eth_initialize() how these functions and their default implementations
are handled.

Best regards,
Beno?t