public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C
Date: Thu, 16 May 2019 16:33:26 +0900	[thread overview]
Message-ID: <679781dc-ae56-6bbb-144f-952c63dbf4e5@samsung.com> (raw)
In-Reply-To: <20190511112433.31367-1-krzk@kernel.org>

Hi,

On 11/05/2019 20:24, Krzysztof Kozlowski wrote:
> The CONFIG_POWER and CONFIG_POWER_I2C were introduced in
> include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix
> build break by adding CONFIG_POWER") and then it propagated up to
> include/configs/arndale.h.  However before that commit, there was no
> build break at all on Arndale and SMDK5250 boards.  It seems the commit
> fixed nothing and just added unused defines.
> 
> In fact, the Arndale board is not configuring its PMIC (S5M8767) which
> uses I2C bus.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> ---
> 
> Not tested on Arndale board. Testing is welcomed.
> 
> Changes since v1:
> 1. Add Simon's tag.
> 2. Reorder patches - first remove CONFIG_POWER_I2C, then
>    CONFIG_DM_I2C_COMPAT.
> ---
>  include/configs/arndale.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/configs/arndale.h b/include/configs/arndale.h
> index dd321c4748d0..841f3616482b 100644
> --- a/include/configs/arndale.h
> +++ b/include/configs/arndale.h
> @@ -29,10 +29,6 @@
>  
>  #define CONFIG_SYS_INIT_SP_ADDR	CONFIG_IRAM_STACK
>  
> -/* PMIC */
> -#define CONFIG_POWER
> -#define CONFIG_POWER_I2C
> -
>  #define CONFIG_PREBOOT
>  
>  #define CONFIG_S5P_PA_SYSRAM	0x02020000
> @@ -41,8 +37,4 @@
>  /* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */
>  #define CONFIG_ARM_GIC_BASE_ADDRESS	0x10480000
>  
> -/* Power */
> -#define CONFIG_POWER
> -#define CONFIG_POWER_I2C
> -
>  #endif	/* __CONFIG_H */
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

      parent reply	other threads:[~2019-05-16  7:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190511112446epcas3p20c09b77c3b0044bac615ec4d4d848149@epcas3p2.samsung.com>
2019-05-11 11:24 ` [U-Boot] [PATCH v2 1/3] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C Krzysztof Kozlowski
2019-05-11 11:24   ` [U-Boot] [PATCH v2 2/3] arm: exynos: arndale: Remove unused CONFIG_DM_I2C_COMPAT Krzysztof Kozlowski
2019-05-16  7:33     ` Minkyu Kang
2019-05-11 11:24   ` [U-Boot] [PATCH v2 3/3] configs: arndale: Use appropriate driver for Asix AX88760 Krzysztof Kozlowski
2019-05-16  7:33     ` Minkyu Kang
2019-05-16  7:33   ` Minkyu Kang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=679781dc-ae56-6bbb-144f-952c63dbf4e5@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox