From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reuben Dowle Date: Mon, 19 Oct 2020 23:02:54 +0000 Subject: [PATCH] Revert "Fix data abort caused by mis-aligning FIT data" In-Reply-To: <4f9c0170-1c52-0f2d-c6f8-972ed082cd36@denx.de> References: <20201019214026.888876-1-marex@denx.de> <669974501aec485c9263fe5127c4ccb5@4rf.com> <38fc6118-b7d7-8455-2c05-3cbe368c4f12@denx.de> <20201019224558.GR14816@bill-the-cat> <4f9c0170-1c52-0f2d-c6f8-972ed082cd36@denx.de> Message-ID: <68533372f458433ab51ffd76fb0d1176@4rf.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > The problem is that the previous alignment was 4 byte, now it is 8 byte and > that breaks all the other assumptions. So, this patch should be reverted to fix > the platforms which used to work (or use ALIGN(...4), which is the same as > reverting it really). What assumptions? Any code that assumes 4 byte alignment will also work on 8 byte alignment. Reverting is not the same as assuming ALIGN(...4) if incoming data is not already aligned to 4 bytes (as was the case when I saw crashes). > > And likely the signed image which caused the breakage should be generated > with mkimage -E / -B 8, which would insure the alignment, so then there is no > need to change anything in the code itself. Interesting. I had not noticed the -B parameter previously. I had originally fixed this issue on an older version of uboot that did not have that option, and later rebased the fix to newer uboot. I would need to do some testing to see if this would fix it as well.