From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Anderson Date: Tue, 27 Oct 2020 14:07:04 -0400 Subject: [PATCH v3 04/23] log: Add new category names to log_cat_name In-Reply-To: <20201027174549.GE14816@bill-the-cat> References: <20201017180749.119271-1-seanga2@gmail.com> <20201017180749.119271-5-seanga2@gmail.com> <20201027174549.GE14816@bill-the-cat> Message-ID: <68952f29-b3d8-7274-1e0a-55b3cfd9624b@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/27/20 1:45 PM, Tom Rini wrote: > On Sat, Oct 17, 2020 at 02:07:29PM -0400, Sean Anderson wrote: > >> Without every category between LOGC_NONE and LOGC_COUNT present in >> log_cat_name, log_get_cat_by_name will dereference NULL pointers if it >> doesn't find a name early enough. >> >> Fixes: c3aed5db59 ("sandbox: spi: Add more logging") >> Fixes: a5c13b68e7 ("sandbox: log: Add a category for sandbox") >> Fixes: 9f407d4ef0 ("Add core support for a bloblist to convey data from SPL") >> Fixes: cce61fc428 ("dm: devres: Convert to use logging") >> Fixes: 7ca2850cbc ("dm: core: Add basic ACPI support") >> >> Signed-off-by: Sean Anderson >> Reviewed-by: Simon Glass > > As Simon has added the missing categories I'm deferring this specific > patch but think it should be re-posted and reworded with the build-time > sanity check as the only change. > I think Heinrich posted a patch for adding a sanity check [1], so this patch can probably be dropped if that is merged. --Sean [1] https://patchwork.ozlabs.org/project/uboot/patch/20201023110001.6261-1-xypron.glpk at gmx.de/