From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE77D0BB5B for ; Thu, 24 Oct 2024 04:04:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BFFB892FD; Thu, 24 Oct 2024 06:04:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="fhehrqDt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F5B0892FD; Thu, 24 Oct 2024 06:04:14 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5A964892F5 for ; Thu, 24 Oct 2024 06:04:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=n-francis@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 49O442RT013667; Wed, 23 Oct 2024 23:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1729742642; bh=f0y0412ProvZdS6/NzBoMwy1F5/1oNgwfg10MDRlQ6o=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=fhehrqDtFYzkC/WAp2UpQnw0v7nQugbmpgATbGNptBiw01ZL5RjMJuB/RAfMq2h50 DyLTsKmGprzVbQRSLbpvkalqY0UXTvH0I//y5OOXEyi8f7RuLdrwh9nVPeqALKrZZ/ vjwUKSC+eNUC/dc/sKLe+mLU5YYw3nsAJOE0xgJI= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 49O4428h038803 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 23 Oct 2024 23:04:02 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 23 Oct 2024 23:04:01 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 23 Oct 2024 23:04:01 -0500 Received: from [172.24.227.36] (a0497641-hp-z2-tower-g9-workstation-desktop-pc.dhcp.ti.com [172.24.227.36] (may be forged)) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 49O43wiK001332; Wed, 23 Oct 2024 23:03:59 -0500 Message-ID: <689bda91-9d6a-4ae4-9ccf-b2e5af6c53cd@ti.com> Date: Thu, 24 Oct 2024 09:33:58 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] drivers: ram: Kconfig: Add CONFIG_K3_INLINE_ECC To: Bryan Brattlof , Santhosh Kumar K CC: , , , , , , References: <20241021044024.835846-1-s-k6@ti.com> <20241021044024.835846-6-s-k6@ti.com> <20241023144559.dtwggwlxwljpky6p@bryanbrattlof.com> Content-Language: en-US From: Neha Malcom Francis In-Reply-To: <20241023144559.dtwggwlxwljpky6p@bryanbrattlof.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Bryan On 23/10/24 20:15, Bryan Brattlof wrote: > On October 21, 2024 thus sayeth Santhosh Kumar K: >> From: Neha Malcom Francis >> >> Add CONFIG_K3_INLINE_ECC so that ECC functions can be compiled into R5 SPL >> only when the config has been enabled. >> >> Signed-off-by: Neha Malcom Francis >> --- >> drivers/ram/Kconfig | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/ram/Kconfig b/drivers/ram/Kconfig >> index f7e357f24da7..533d0c629a64 100644 >> --- a/drivers/ram/Kconfig >> +++ b/drivers/ram/Kconfig >> @@ -116,6 +116,16 @@ config IMXRT_SDRAM >> to support external memories like sdram, psram & nand. >> This driver is for the sdram memory interface with the SEMC. >> >> +config K3_INLINE_ECC >> + bool "Enable TI Inline ECC support" >> + depends on K3_DDRSS >> + help >> + Enable Inline ECC support on K3 platforms. 1/9th of the SDRAM space >> + is used for ECC storage and the rest 8/9th is available for system >> + use. Enabling ECC increases boot time as the ECC protected regions >> + need to be primed with a predefined value prior to enabling ECC >> + check. >> + > > I agree size will always be a complaint at such an early stage of boot > but we're already adding the ECC configuration in the memory{} node. > > We should do one or the other but not both. It would be hard to debug > problems if someone added the protected{} node but not enable this > config Actually I do agree with this, maybe we can get rid of the flag ti,ecc-enable which is redundant. In multi-DDR systems, it was still a possibility that we could use it to select the DDR we want ECC enabled on, but that hasn't been tested nor does it make any sense since they'll be interleaved anyways. -- Thanking You Neha Malcom Francis