From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14201C36002 for ; Sun, 23 Mar 2025 05:08:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0BABA806FC; Sun, 23 Mar 2025 06:08:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="VyQsPi8n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DCFAB80F0E; Sun, 23 Mar 2025 06:08:41 +0100 (CET) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id CF6278059D for ; Sun, 23 Mar 2025 06:08:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut@mailbox.org Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4ZL42s54kWz9sbs; Sun, 23 Mar 2025 06:08:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1742706517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3qDyGwNoRK2ZH77kQmQ6jM5pFbtc0BOI58SEKiNmQCk=; b=VyQsPi8nxhFg0+4UnMnv+H2C7XhJWDujx0WB5mV0/V+D43mer8WbTNltDFzunfQzcjg0TB FiW11pLlUgBTgnjY3NJP/ti45jwkxOyFJsIAS3kTItqe+CYsVA9UfkoxLAkL9y6s+W5n38 /ArWQ42cf/uIHjs6RQ/wrOBPUASI9dn7v5VG8EyVxCnSlRv1zk1iNyYHtj9Aig/hUFUnNL /gxhYcCAAHtyf8IGZJgrwTEOIVetgzJ5ezQmm16Ca1hGeCoPYUbbqskZgdHN6BKT6JC5iU tKtfN/7p/fQQF950HLSsyVZ48IqEqZ5kzA6G00D+nASZC1uan/ki14HjDERdJg== Message-ID: <68c9c45d-fa1e-40da-a094-038efe9afd46@mailbox.org> Date: Sun, 23 Mar 2025 06:08:33 +0100 MIME-Version: 1.0 Subject: Re: [PATCH V3 3/6] cpu: imx8_cpu: Print Speed grade if IMX_THERMAL or IMX_TMU To: Adam Ford Cc: u-boot@lists.denx.de, aford@beaconembedded.com, festevam@gmail.com, Stefano Babic , "NXP i.MX U-Boot Team" , Tom Rini , Enrico Leto , Heiko Schocher , Peng Fan , Yannic Moog , Sumit Garg , Gilles Talis , Marcel Ziswiler , Ye Li , Wadim Egorov , Christoph Stoidner , Hou Zhiqiang , Michael Trimarchi References: <20250322183812.784676-1-aford173@gmail.com> <20250322183812.784676-4-aford173@gmail.com> <16100abb-70da-4b0b-a5de-3e961c0551d9@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-MBO-RS-ID: a438825bc91c70b582a X-MBO-RS-META: akwyh37yabwp3ehr8iq5hbrqmscbbkx6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 3/23/25 1:03 AM, Adam Ford wrote: > On Sat, Mar 22, 2025 at 6:31 PM Marek Vasut wrote: >> >> On 3/22/25 7:38 PM, Adam Ford wrote: >>> Much of the data that is display by imx8_cpu.c is also displayed from >>> arch/arm/mach-imx/cpu.c, except the temperature grade and active >>> temperature are only displayed when SoC is an i.MX9. Since IMX9 now >>> implies IMX_TMU, change this to check for IMX_THERMAL or IMX_TMU >>> in the same way it's done in mach-imx/cpu.c to enable displaying >>> this information for any SoC with either of these configs enabled. >>> >>> Before: >>> CPU: NXP i.MX8MP Rev1.1 A53 at 1200 MHz >>> Model: Beacon EmbeddedWorks i.MX8MPlus Development kit >>> >>> After: >>> CPU: NXP i.MX8MP Rev1.1 A53 at 1200 MHz >>> CPU: Industrial temperature grade (-40C to 105C) at 28C >> There is an extra space after 'grade' , please fix. > > No problem. Should that be its own patch, or can I roll the > whitespace change with the #ifdef change? Normally, I like to keep > them separate, but it seems silly to me to make a patch solely for a > 1-character whitespace change. Either way works for me, as long as it gets fixed. Thanks !