From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alper Nebi Yasak Date: Wed, 14 Oct 2020 23:39:40 +0300 Subject: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce() In-Reply-To: <20201014193113.GS14816@bill-the-cat> References: <20201006203951.18040-1-alpernebiyasak@gmail.com> <469bd776-c20a-32c7-ad8d-32adb5b378c7@gmail.com> <20201014152433.GV14816@bill-the-cat> <20201014193113.GS14816@bill-the-cat> Message-ID: <68f74cb8-afcf-b033-e211-363c0f29f206@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 14/10/2020 22:31, Tom Rini wrote: > On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: >> On 14/10/2020 18:24, Tom Rini wrote: >>> Ugh. In so far as anything can be re-licensed, who did it all >>> originally? I suspect coreboot isn't interested in 2.0+ but we can do >>> 2.0-only. >> >> For this patch, coreboot commit b9a7877568cf ("rockchip/*: refactor edp >> driver") introduces the related change to src/soc/rockchip/common/edp.c >> renamed from .../rk3288/edp.c, which was introduced at coreboot commit >> 40f558e8f4f7 ("rockchip: support display"). > > Right, sorry. I mean, on the U-Boot side, where did things come from? > I wonder how we got a different license text, and perhaps if we > shouldn't just re-port the coreboot code over as a clean/clear way to > re-license it to GPL-2.0-only. I'm not sure re-porting is a great idea from the technical perspective. I've been reading both drivers to compare them, there are also things in U-Boot that're missing from coreboot. Things like DM integration are also not there as they're U-Boot specific. I checked some files with git log and checked the first commit that showed up for each. Simon Glass added: - drivers/video/rockchip/rk_edp.c - drivers/video/rockchip/rk_hdmi.c - drivers/video/rockchip/rk_vop.c - arch/arm/include/asm/arch-rockchip/vop_rk3288.h - arch/arm/include/asm/arch-rockchip/edp_rk3288.h as Copyright (c) 2015 Google, Inc Copyright 2014 Rockchip Inc. Philipp Tomsich added: - drivers/video/rockchip/rk3288_hdmi.c - drivers/video/rockchip/rk3399_hdmi.c - drivers/video/rockchip/rk_hdmi.h - drivers/video/rockchip/rk_vop.h as Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH - drivers/video/rockchip/rk3288_vop.c - drivers/video/rockchip/rk3399_vop.c as Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH Copyright (c) 2015 Google, Inc Copyright 2014 Rockchip Inc. Eric Gao added: - drivers/video/rockchip/rk3288_mipi.c - drivers/video/rockchip/rk3399_mipi.c - drivers/video/rockchip/rk_mipi.c - drivers/video/rockchip/rk_mipi.h - arch/arm/include/asm/arch-rockchip/rockchip_mipi_dsi.h as Copyright (C) 2017 Fuzhou Rockchip Electronics Co., Ltd Jacob Chen added: - drivers/video/rockchip/rk_lvds.c - arch/arm/include/asm/arch-rockchip/lvds_rk3288.h as Copyright 2016 Rockchip Inc.