public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ron Madrid <ron_madrid@sbcglobal.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Exclude certain ns16550 functions from NAND_SPL builds
Date: Thu, 29 Jan 2009 09:28:44 -0800 (PST)	[thread overview]
Message-ID: <697520.19982.qm@web83507.mail.sp1.yahoo.com> (raw)
In-Reply-To: <20090129102451.C1DB5832E416@gemini.denx.de>

--- On Thu, 1/29/09, Wolfgang Denk <wd@denx.de> wrote:

> From: Wolfgang Denk <wd@denx.de>
> Subject: Re: [U-Boot] [PATCH] Exclude certain ns16550 functions from NAND_SPL builds
> To: "Ron Madrid" <ron_madrid@sbcglobal.net>
> Cc: u-boot at lists.denx.de
> Date: Thursday, January 29, 2009, 2:24 AM
> Dear Ron Madrid,
> 
> In message
> <1233187331-20244-1-git-send-email-ron_madrid@sbcglobal.net>
> you wrote:
> > This patch will exclude all functions from
> drivers/serial/ns16550.c from
> > NAND_SPL builds with exception of NS16550_putc and
> NS16550_init.  This will save
> > space and remove unused code from already tightly
> constrained bootstrap images
> > for NAND_SPL builds.
> > 
> > Signed-off-by: Ron Madrid
> <ron_madrid@sbcglobal.net>
> > ---
> >  drivers/serial/ns16550.c |    5 ++++-
> >  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> This is a global file, so maybe we could use a less
> specific #define
> than CONFIG_NAND_SPL for this? Eventually we need this
> later to boot
> from device FOO, and I don't want to see this grow into
> 
> if !defined(CONFIG_NAND_SPL) &&
> !defined(CONFIG_FOO) && !defined(CONFIG_BAR)
> && ...

I understand your concern.  I am not sure what other #define would work.
Are you suggesting the creation of a new #define such as #define
CONFIG_NS16550_BASIC_OPS or something like that which can be put into the
board specific config files?

Ron

  reply	other threads:[~2009-01-29 17:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29  0:02 [U-Boot] [PATCH] Exclude certain ns16550 functions from NAND_SPL builds Ron Madrid
2009-01-29 10:24 ` Wolfgang Denk
2009-01-29 17:28   ` Ron Madrid [this message]
2009-01-29 19:05     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=697520.19982.qm@web83507.mail.sp1.yahoo.com \
    --to=ron_madrid@sbcglobal.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox