From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3] FAT: Make it possible to read from any file position
Date: Fri, 28 Sep 2012 13:32:28 +0200 (CEST) [thread overview]
Message-ID: <698056304.5413659.1348831948222.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20120927162055.GA14678@bill-the-cat>
Hi Tom,
On Thursday, September 27, 2012 6:20:55 PM, Tom Rini wrote:
> On Tue, Sep 18, 2012 at 08:14:56AM -0000, Beno?t Th?baudeau wrote:
>
> > When storage devices contain files larger than the embedded RAM, it
> > is useful to
> > be able to read these files by chunks, e.g. for a software update
> > to the
> > embedded NAND Flash from an external storage device (USB stick, SD
> > card, etc.).
> >
> > Hence, this patch makes it possible by adding a new FAT API to read
> > files from a
> > given position. This patch also adds this feature to the fatload
> > command.
> >
> > Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> > Cc: Tom Rini <trini@ti.com>
> > Cc: Wolfgang Denk <wd@denx.de>
>
> With a reformatting of the commit message and making the changes
> re-apply to master, I've applied this to u-boot/master, thanks!
Perfect.
I have a concern regarding the two patches that came in between:
[1] http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=cfda5aeab89d73779e26f0d34cf10f64caa67431
[2] http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commitdiff;h=10a37fd7a40826c43a63591855346adf1a1ac02d
Perhaps I'm wrong, and I admit I have not tested them, but looking at the code,
it seems to me that [2] breaks the "-" in the following feature of [1]:
"With the common function "dev:part" can come from the environment and a '-' can
be used in that case."
Hence, tests like "if (argc < 5)" in do_fat_fsload() get broken.
Also, the command usage message marks dev:part as optional, but it does not say
that this should actually be replaced by "-" if skipped.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-09-28 11:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 22:03 [U-Boot] [PATCH 7/7] FAT: Make it possible to read from any file position Benoît Thébaudeau
2012-07-19 22:44 ` Mike Frysinger
2012-07-19 23:17 ` Benoît Thébaudeau
2012-07-20 3:02 ` Mike Frysinger
2012-07-20 13:22 ` [U-Boot] [PATCH v2 8/8] " Benoît Thébaudeau
2012-09-02 15:28 ` Wolfgang Denk
2012-09-03 14:17 ` Benoît Thébaudeau
2012-09-14 20:49 ` Tom Rini
2012-09-14 22:03 ` Benoît Thébaudeau
2012-09-14 22:02 ` Tom Rini
2012-09-22 20:32 ` Benoît Thébaudeau
2012-09-18 18:14 ` [U-Boot] [PATCH v3] " Benoît Thébaudeau
2012-09-27 16:20 ` [U-Boot] [U-Boot, " Tom Rini
2012-09-28 11:32 ` Benoît Thébaudeau [this message]
2012-09-28 15:34 ` Stephen Warren
2012-09-28 16:17 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698056304.5413659.1348831948222.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox