public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] watchdog: bcm6345: convert to use live dt
Date: Sat, 17 Mar 2018 19:39:39 +0100	[thread overview]
Message-ID: <6984da12-2e76-8c46-da61-1a67a849e239@gmail.com> (raw)
In-Reply-To: <20180317112317.9352-1-noltari@gmail.com>



On 17.03.2018 12:23, Álvaro Fernández Rojas wrote:
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
>  drivers/watchdog/bcm6345_wdt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/bcm6345_wdt.c b/drivers/watchdog/bcm6345_wdt.c
> index 3ef7d438a6..90b33aadf1 100644
> --- a/drivers/watchdog/bcm6345_wdt.c
> +++ b/drivers/watchdog/bcm6345_wdt.c
> @@ -87,13 +87,12 @@ static int bcm6345_wdt_probe(struct udevice *dev)
>  {
>  	struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
>  	fdt_addr_t addr;
> -	fdt_size_t size;
>  
> -	addr = devfdt_get_addr_size_index(dev, 0, &size);
> +	addr = dev_read_addr(dev);
>  	if (addr == FDT_ADDR_T_NONE)
>  		return -EINVAL;
>  
> -	priv->regs = ioremap(addr, size);
> +	priv->regs = ioremap(addr, 0);

as this pattern is repeated in each driver which have to do such
remapping on archs like MIPS, I suggest to add generic wrapper functions
for this like:

void *dev_read_addr_and_remap_index(struct udevice *dev, int index)

void *dev_read_addr_and_remap(struct udevice *dev)

>  
>  	bcm6345_wdt_stop(dev);
>  
> 

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180317/86c0777d/attachment.sig>

  reply	other threads:[~2018-03-17 18:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17 11:23 [U-Boot] [PATCH] watchdog: bcm6345: convert to use live dt Álvaro Fernández Rojas
2018-03-17 18:39 ` Daniel Schwierzeck [this message]
2018-03-19 17:59   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6984da12-2e76-8c46-da61-1a67a849e239@gmail.com \
    --to=daniel.schwierzeck@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox