public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Andre Heider <a.heider@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE
Date: Sun, 6 Sep 2020 21:00:30 +0200	[thread overview]
Message-ID: <69f549d3-c17c-b316-3957-186fbc3a24a0@gmail.com> (raw)
In-Reply-To: <20200905100210.5627-1-xypron.glpk@gmx.de>

On 05/09/2020 12:02, Heinrich Schuchardt wrote:
> Symbol CONFIG_DEFAULT_CONSOLE in include/configs/espresso7420.h is not used
> for espresso7420_defconfig.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

I noticed that too while grepping for CONFIG_DEFAULT_CONSOLE. Afaict 
there're quite some boards with it set but unused:
include/configs/arndale.h
include/configs/peach-pi.h
include/configs/peach-pit.h
include/configs/smdk5250.h
include/configs/smdkv310.h
include/configs/snow.h
include/configs/spring.h

This one even defines it twice (looks like a rebase gone wrong), still 
unused:
include/configs/smdk5420.h
#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC1,115200n8\0"
#define CONFIG_DEFAULT_CONSOLE		"console=ttySAC1,115200n8\0"

Last but not least:
include/configs/origen.h
#define CONFIG_DEFAULT_CONSOLE		"console=ttySAC1,115200n8\0"
"console=ttySAC2,115200n8\0"

Btw, *all* hits for CONFIG_DEFAULT_CONSOLE are ttySAC*.

Regards,
Andre

> ---
>   include/configs/espresso7420.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/configs/espresso7420.h b/include/configs/espresso7420.h
> index 5aeb009f03..2495db93f8 100644
> --- a/include/configs/espresso7420.h
> +++ b/include/configs/espresso7420.h
> @@ -18,9 +18,6 @@
>   #define CONFIG_SPL_STACK		CONFIG_IRAM_END
>   #define CONFIG_SYS_INIT_SP_ADDR		CONFIG_IRAM_END
> 
> -/* select serial console configuration */
> -#define CONFIG_DEFAULT_CONSOLE	"console=ttySAC1,115200n8\0"
> -
>   /* DRAM Memory Banks */
>   #define SDRAM_BANK_SIZE		(256UL << 20UL)	/* 256 MB */
> 
> --
> 2.28.0
> 

  parent reply	other threads:[~2020-09-06 19:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 10:02 [PATCH 1/1] espresso7420: remove unused symbol CONFIG_DEFAULT_CONSOLE Heinrich Schuchardt
2020-09-05 10:55 ` Fwd: " Heinrich Schuchardt
2020-09-07  0:06   ` Thomas Abraham
2020-09-06 19:00 ` Andre Heider [this message]
2020-09-06 19:33   ` Heinrich Schuchardt
2020-09-07  5:10     ` Minkyu Kang
2020-10-15  5:36       ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69f549d3-c17c-b316-3957-186fbc3a24a0@gmail.com \
    --to=a.heider@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox