From: Felix Brack <fb@ltec.ch>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: dts: am33xx: introduce 'am33xx-u-boot.dtsi'
Date: Thu, 7 Feb 2019 17:47:27 +0100 [thread overview]
Message-ID: <6a34f445-2cda-d1df-399d-3eb01c0abb6e@ltec.ch> (raw)
In-Reply-To: <1549453790-11692-1-git-send-email-hannes.schmelzer@br-automation.com>
Hi Hannes,
On 06.02.19 12:49, Hannes Schmelzer wrote:
> commit fdce9d35dc36 ("arm: dts: am33xx: Sync dts with Linux 4.20.0")
> did remove the "u-boot,dm-spl" flag from the 'ocp' bus which was
> introduced with
> commit 19aa4ac09db9 ("dts: am33xx: add u-boot, dm-spl to ocp bus")
>
> Due to this all boards having CONFIG_SPL_OF_CONTROL enabled are broken
> because they cannot bind/probe the boot-media interface during SPL
> stage.
>
Not all boards were broken, only those not having set that property in
their proper -u-boot.dtsi or dts file (like am335x-pdu001-u-boot.dtsi).
> This commit introduces the 'am33xx-u-boot.dtsi' which is included with
> the auto include mechanism. The am33xx-u-boot-dtsi adds the important
> "u-boot,dm-pre-reloc" to the 'ocp bus' (the root bus of almost all
> peripherals, at least the bootable ones).
>
If the new am33xx-u-boot.dtsi file gets include automatically then
setting the same property in the board specific dts/dtsi file is
redundant. Hence please remove the property from those files (like from
am335x-pdu001-u-boot.dtsi) and add those modified files to your patch.
Thus we have one single patch fixing this issue. Many thanks!
retards Felix
> The peripherials (mmc, spi, ...) needed during SPL stage need to be
> equipped with the 'u-boot,dm-pre-reloc' in their responsible dts file.
>
> Signed-off-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>
>
> ---
>
> Changes in v2:
> - use u-boot,dm-pre-reloc instead u-boot,dm-spl
> - add am33xx-u-boot.dtsi instead modifying the am33xx.dtsi
>
> arch/arm/dts/am33xx-u-boot.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 arch/arm/dts/am33xx-u-boot.dtsi
>
> diff --git a/arch/arm/dts/am33xx-u-boot.dtsi b/arch/arm/dts/am33xx-u-boot.dtsi
> new file mode 100644
> index 0000000..78f5e2c
> --- /dev/null
> +++ b/arch/arm/dts/am33xx-u-boot.dtsi
> @@ -0,0 +1,11 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2019 B&R Industrial Automation GmbH -
> + * https://www.br-automation.com/
> + */
> +
> +/ {
> + ocp {
> + u-boot,dm-pre-reloc;
> + };
> +};
>
next prev parent reply other threads:[~2019-02-07 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 11:49 [U-Boot] [PATCH v2] arm: dts: am33xx: introduce 'am33xx-u-boot.dtsi' Hannes Schmelzer
2019-02-07 16:47 ` Felix Brack [this message]
2019-02-07 17:14 ` Hannes Schmelzer
2019-02-08 15:10 ` Felix Brack
2019-02-08 3:13 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a34f445-2cda-d1df-399d-3eb01c0abb6e@ltec.ch \
--to=fb@ltec.ch \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox