From mboxrd@z Thu Jan  1 00:00:00 1970
From: R, Vignesh <vigneshr@ti.com>
Date: Tue, 26 Jul 2016 12:28:12 +0530
Subject: [U-Boot] [PATCH 3/4] net: cpsw: Add support to drive gpios for
 ethernet to be functional
In-Reply-To: <20160726065605.50CBF100C4F@atlas.denx.de>
References: <20160725131023.30656-1-vigneshr@ti.com>
 <20160725131023.30656-4-vigneshr@ti.com>
 <20160725133846.GJ14698@bill-the-cat>
 <a210f61e-bf51-a946-013c-dd98fd9a17b0@ti.com>
 <20160726065605.50CBF100C4F@atlas.denx.de>
Message-ID: <6c2c41f7-2e08-ef6a-6c10-5ac91c12bd7d@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On 7/26/2016 12:26 PM, Wolfgang Denk wrote:
> Dear "R, Vignesh",
> 
> In message <a210f61e-bf51-a946-013c-dd98fd9a17b0@ti.com> you wrote:
>>
>>>> @@ -1203,6 +1206,16 @@ static int cpsw_eth_ofdata_to_platdata(struct udevice *dev)
>>>>  		return -ENOENT;
>>>>  	}
>>>>  
>>>> +
>>>> +	num_mode_gpios = gpio_get_list_count(dev, "mode-gpios");
>>>
>>> Extra blank line added.
>>
>> I added blank line for readability. So, that code block handling
>> toggling of "mode-gpios" is separated from the rest. I can remove that
>> if that seems unnecessary.
> 
> There was already a blank line which provides enough separation. No
> need to have multiple consecutive blank lines.

Sorry, will clean that up in v2. Thanks!

Regards
Vignesh