Re: [PATCH v3 02/15] arm: mach-k3: am62x: am625_init: Remove explicit probing of CPSW driver

[Roger Quadros <rogerq@kernel.org>]

On 25/02/2025 13:48, Chintan Vankar wrote:
> Bind method of am65_cpsw_nuss driver will ensure binding of it's child
> driver am65_cpsw_nuss_ports, and there is no need to call CPSW driver
> explicitly. Remove explicit probing of CPSW driver for AM62x.
> 
> Signed-off-by: Chintan Vankar <c-vankar@ti.com>

You should just revert commit 35bddf889652 ("arm: mach-k3: am62x: am625_init: Probe AM65 CPSW NUSS")

> ---
> 
> Link to v2:
> https://lore.kernel.org/r/20250219104831.2315464-4-c-vankar@ti.com/
> 
> Changes from v2 to v3:
> - Updated commit subject and commit message.
> 
>  arch/arm/mach-k3/am62x/am625_init.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm/mach-k3/am62x/am625_init.c b/arch/arm/mach-k3/am62x/am625_init.c
> index 595fc391ac5..72a752d38e8 100644
> --- a/arch/arm/mach-k3/am62x/am625_init.c
> +++ b/arch/arm/mach-k3/am62x/am625_init.c
> @@ -282,15 +282,6 @@ void board_init_f(ulong dummy)
>  	}
>  	spl_enable_cache();
>  
> -	if (IS_ENABLED(CONFIG_SPL_ETH) && IS_ENABLED(CONFIG_TI_AM65_CPSW_NUSS) &&
> -	    spl_boot_device() == BOOT_DEVICE_ETHERNET) {
> -		struct udevice *cpswdev;
> -
> -		if (uclass_get_device_by_driver(UCLASS_MISC, DM_DRIVER_GET(am65_cpsw_nuss),
> -						&cpswdev))
> -			printf("Failed to probe am65_cpsw_nuss driver\n");
> -	}
> -
>  	fixup_a53_cpu_freq_by_speed_grade();
>  }
>  

what about mach-k3/am64x/am642_init.c?
Please revert the relevant commit there as well.

and the same thing done in mach-k3/common.c?
Please revert the relevant commit there too.

It would be OK if you squash all 3 reverts into one patch.

As a separate patch you will also have to remove the part where cpsw_port2 node is
disabled in various k3-*-u-boot.dtsi files [1]. That is no longer needed as now we should
be able to support multiple ethernet ports.

[1] -
k3-am625-beagleplay-u-boot.dtsi:&cpsw_port2 {
k3-am625-phyboard-lyra-rdk-u-boot.dtsi:&cpsw_port2 {
k3-am625-sk-u-boot.dtsi:&cpsw_port2 {
k3-am642-evm-u-boot.dtsi:&cpsw_port2 {
k3-am642-sk-u-boot.dtsi:&cpsw_port2 {

-- 
cheers,
-roger