From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Johnson Date: Mon, 23 Mar 2020 09:38:25 -0600 Subject: [PATCH 1/2] arm: mvebu: clearfog: add SCSI to distro bootcmd In-Reply-To: <053ebf42-a409-95f3-5bb7-39650e192556@denx.de> References: <20200129035945.37765-1-mrjoel@lixil.net> <71e0843522cf94172fd84affc604c086@lixil.net> <053ebf42-a409-95f3-5bb7-39650e192556@denx.de> Message-ID: <6c98454ca6761e69687e5d4664e4c574@lixil.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2020-03-23 04:27, Stefan Roese wrote: > Hi Joel, > > On 22.03.20 19:53, Joel Johnson wrote: >> As with other related ClearFog patches, I haven't received any review >> responses on this series >> (http://patchwork.ozlabs.org/project/uboot/list/?series=155760) and >> would like to ping out for additional review. I'd especially like >> feedback on the approach for support of multiple SCSI devices, if >> there a preferred or standardized mechanism I'd be happy to adjust, >> but I couldn't find any other examples of including multiple SCSI >> devices in distro_boot. In reviewing again myself there was an initial >> mental mismatch between CON2/CON3 usage as connection ports and the >> naming of SCSI_CLEARFOG2/SCSI_CLEARFOG3 as index counters, but >> otherwise still seems good. >> >> If it's in an acceptable state for inclusion in the next merge window, >> that's certainly fine too, I'm just looking for a crosscheck. > > Let's see, if Baruch and/or Josua have some comments here. > > Thanks, > Stefan I have an update I'll post shortly which keeps the same logic, but renames the defined macros to be SCSI bus centric (i.e. X_BUS0, X_BUS1, X_BUS2) instead of potential confusion with hardware labelled port locations. Joel