public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: trini@konsulko.com
Cc: u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] docs: fix wrong proftool usage
Date: Tue, 25 Apr 2023 16:41:52 +0300	[thread overview]
Message-ID: <6d27cac2-bc0a-358e-83e9-957094f18fee@gmail.com> (raw)
In-Reply-To: <CAPnjgZ2q8emotibbHy6wQOm=RoeOMkqZ-jN8yCz9B6efQ9H2TA@mail.gmail.com>

Hi Simon,

Simon Glass <sjg@chromium.org> says:
> On Wed, 12 Apr 2023 at 13:05, Pavel Skripkin <paskripkin@gmail.com> wrote:
>>
>> Guide shows incorrect usage of proftool, which is confusing. If proftool
>> is used w/o '-o' argument it complains like following
>>
>> $ ./sandbox/tools/proftool -m sandbox/System.map -t trace dump-ftrace > trace.dat
>> Must provide trace data, System.map file and output file
>> Usage: proftool [-cmtv] <cmd> <profdata>
>>
>> s/>/-o/ fixes it and proftool outputs decoded data to trace.dat
>>
>> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
>> ---
>>  doc/develop/trace.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg@chromium.org>

Thank you for review!

+Tom, I guess?

@Tom, could you, please, pick following patch?


https://lists.denx.de/pipermail/u-boot/2023-April/515194.html




With regards,
Pavel Skripkin

  reply	other threads:[~2023-04-25 13:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 19:05 [PATCH] docs: fix wrong proftool usage Pavel Skripkin
2023-04-19  1:45 ` Simon Glass
2023-04-25 13:41   ` Pavel Skripkin [this message]
2023-04-25 13:58     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d27cac2-bc0a-358e-83e9-957094f18fee@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox