Re: [PATCH v2 14/23] imx: power-domain: Inline arch-imx8m/power-domain.h

Jaehoon Chung
2022-04-18T00:23:40Z

On 4/12/22 04:45, Marek Vasut wrote:
> The arch/arm/include/asm/arch-imx8m/power-domain.h is not included
> anywhere except in drivers/power/domain/imx8m-power-domain.c, just
> inline the content and drop the header. No functional change.
>
> Tested-By: Tim Harvey <tharvey@gateworks.com> #imx8mp-venice-defconfig
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
> V2: Add TB by Tim
> ---
> arch/arm/include/asm/arch-imx8m/power-domain.h | 15 ---------------
> drivers/power/domain/imx8m-power-domain.c | 7 ++++++-
> 2 files changed, 6 insertions(+), 16 deletions(-)
> delete mode 100644 arch/arm/include/asm/arch-imx8m/power-domain.h
>
> diff --git a/arch/arm/include/asm/arch-imx8m/power-domain.h b/arch/arm/include/asm/arch-imx8m/power-domain.h
> deleted file mode 100644
> index 7a833e564b5..00000000000
> --- a/arch/arm/include/asm/arch-imx8m/power-domain.h
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 */
> -/*
> - * Copyright 2017 NXP
> - */
> -
> -#ifndef _ASM_ARCH_IMX8M_POWER_DOMAIN_H
> -#define _ASM_ARCH_IMX8M_POWER_DOMAIN_H
> -
> -struct imx8m_power_domain_plat {
> - int resource_id;
> - int has_pd;
> - struct power_domain pd;
> -};
> -
> -#endif
> diff --git a/drivers/power/domain/imx8m-power-domain.c b/drivers/power/domain/imx8m-power-domain.c
> index ac7411f8327..c32dbcc31ae 100644
> --- a/drivers/power/domain/imx8m-power-domain.c
> +++ b/drivers/power/domain/imx8m-power-domain.c
> @@ -9,7 +9,6 @@
> #include <power-domain-uclass.h>
> #include <asm/global_data.h>
> #include <asm/io.h>
> -#include <asm/arch/power-domain.h>
> #include <asm/mach-imx/sys_proto.h>
> #include <dm/device-internal.h>
> #include <dm/device.h>
> @@ -18,6 +17,12 @@
>
> DECLARE_GLOBAL_DATA_PTR;
>
> +struct imx8m_power_domain_plat {
> + int resource_id;
> + int has_pd;
> + struct power_domain pd;
> +};
> +
> static int imx8m_power_domain_on(struct power_domain *power_domain)
> {
> struct udevice *dev = power_domain->dev;