From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Fri, 9 Jun 2017 14:43:12 +0200 Subject: [U-Boot] [PATCH v2] buildman: Translate binutils output to UTF-8 In-Reply-To: References: <20170531134002.5360-1-daniel.schwierzeck@gmail.com> <20170607121901.16873-1-daniel.schwierzeck@gmail.com> Message-ID: <6d9314cc-d1f8-064c-6a5f-76d41c052f02@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 09.06.2017 um 14:27 schrieb Simon Glass: > Hi Daniel, > > On 7 June 2017 at 10:03, Daniel Schwierzeck > wrote: >> >> >> Am 07.06.2017 um 17:52 schrieb Simon Glass: >>> Hi Daniel, >>> >>> On 7 June 2017 at 06:19, Daniel Schwierzeck >>> wrote: >>>> binutils are using localized output. On systems with locales and special >>>> characters this leads to exceptions like this: >>>> >>>> Exception in thread Thread-7: >>>> Traceback (most recent call last): >>>> File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner >>>> self.run() >>>> File "/u-boot/tools/buildman/builderthread.py", line 475, in run >>>> self.RunJob(job) >>>> File "/u-boot/tools/buildman/builderthread.py", line 456, in RunJob >>>> self._WriteResult(result, job.keep_outputs) >>>> File "/u-boot/tools/buildman/builderthread.py", line 333, in _WriteResult >>>> print >>fd, dump_result.stdout, >>>> UnicodeEncodeError: 'ascii' codec can't encode characters in position 75-76: ordinal not in range(128) >>>> >>>> Always encode the value of CommandResult::stdout to UTF-8 before >>>> writing it to stdout or a log file. >>>> >>>> Signed-off-by: Daniel Schwierzeck >>>> >>>> --- >>>> >>>> Changes in v2: >>>> - encode all occurences of CommandResult::stdout after spawning binutils to UTF-8 >>>> - reworded commit message >>>> >>>> tools/buildman/builderthread.py | 10 +++++----- >>>> 1 file changed, 5 insertions(+), 5 deletions(-) >>>> >>> >>> I'm still seeing a rare failure, e.g.: >>> >>> https://travis-ci.org/sglass68/u-boot/jobs/240350621 >>> >>> Any thoughts on that? >>> >> >> I'll look into it > > Thanks. I believe the two new patches you sent supersede this one. > yes, this one is superseded. -- - Daniel -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: OpenPGP digital signature URL: