public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358
Date: Sat, 15 Apr 2017 19:18:17 +0200	[thread overview]
Message-ID: <6def57db-2f7f-9cd0-8e01-af2d415893f8@gmail.com> (raw)
In-Reply-To: <56b2df89-5915-c68d-3d4a-3ade6564600d@gmail.com>

Hi Daniel,

El 14/04/2017 a las 20:26, Daniel Schwierzeck escribió:
> 
> 
> Am 13.04.2017 um 17:52 schrieb Álvaro Fernández Rojas:
>> BCM6358 has its internal registers mapped to 0xfffe0000, which is changed to
>> 0x1ffe0000 when ioremap is called.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>> ---
>>  arch/mips/include/asm/mach-generic/ioremap.h | 15 ++++++++++++++-
>>  1 file changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/include/asm/mach-generic/ioremap.h b/arch/mips/include/asm/mach-generic/ioremap.h
>> index 6b191d5..b6a920d 100644
>> --- a/arch/mips/include/asm/mach-generic/ioremap.h
>> +++ b/arch/mips/include/asm/mach-generic/ioremap.h
>> @@ -16,15 +16,28 @@ static inline phys_addr_t fixup_bigphys_addr(phys_addr_t phys_addr,
>>  	return phys_addr;
>>  }
>>  
>> +static inline int is_mips_internal_registers(phys_addr_t offset)
>> +{
>> +#ifdef CONFIG_SOC_BMIPS_BCM6358
>> +	if (offset >= 0xfffe0000)
>> +		return 1;
>> +#endif
>> +
>> +	return 0;
>> +}
>> +
>>  static inline void __iomem *plat_ioremap(phys_addr_t offset, unsigned long size,
>>  						unsigned long flags)
>>  {
>> +	if (is_mips_internal_registers(offset))
>> +		return (void __iomem *)offset;
>> +
>>  	return NULL;
>>  }
>>  
>>  static inline int plat_iounmap(const volatile void __iomem *addr)
>>  {
>> -	return 0;
>> +	return is_mips_internal_registers((unsigned long)addr);
>>  }
>>  
>>  #define _page_cachable_default	_CACHE_CACHABLE_NONCOHERENT
>>
> 
> please create a separate ioremap.h in arch/mips/include/asm/mach-bmips/
> with the BMIPS specific code. Then this file will be automatically used
> instead of the generic version. This is working like in Linux kernel.
I will try, but I remember having tested that and I couldn't get it working...

> 

  reply	other threads:[~2017-04-15 17:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1492098775-3518-1-git-send-email-noltari@gmail.com>
     [not found] ` <1492098775-3518-2-git-send-email-noltari@gmail.com>
2017-04-14 17:43   ` [U-Boot] [PATCH 1/8] cmd: cpu: fix NULL cpu feature prints Daniel Schwierzeck
2017-04-15 17:16     ` Álvaro Fernández Rojas
     [not found] ` <1492098775-3518-5-git-send-email-noltari@gmail.com>
2017-04-14 18:19   ` [U-Boot] [PATCH 4/8] serial: add serial driver for BCM6345 Daniel Schwierzeck
2017-04-15 17:17     ` Álvaro Fernández Rojas
     [not found] ` <1492098775-3518-8-git-send-email-noltari@gmail.com>
2017-04-14 18:26   ` [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358 Daniel Schwierzeck
2017-04-15 17:18     ` Álvaro Fernández Rojas [this message]
2017-04-15 18:08       ` Álvaro Fernández Rojas
2017-04-15 18:48         ` Daniel Schwierzeck
2017-04-15 19:15           ` Álvaro Fernández Rojas
     [not found] ` <1492098775-3518-9-git-send-email-noltari@gmail.com>
2017-04-14 19:05   ` [U-Boot] [PATCH 8/8] mips: bmips: add support for raw .elf images Daniel Schwierzeck
2017-04-15 17:19     ` Álvaro Fernández Rojas
2017-04-15 18:10       ` Álvaro Fernández Rojas
2017-04-15 18:54         ` Daniel Schwierzeck
2017-04-15 19:14           ` Álvaro Fernández Rojas
2017-04-15 19:30             ` Álvaro Fernández Rojas
     [not found] ` <1492098775-3518-6-git-send-email-noltari@gmail.com>
2017-04-14 19:23   ` [U-Boot] [PATCH 5/8] mips: add support for Broadcom MIPS Daniel Schwierzeck
2017-04-15 17:24     ` Álvaro Fernández Rojas
2017-04-13 15:44 [U-Boot] [PATCH 0/8] Add support for Broadcom MIPS SoCs Álvaro Fernández Rojas
2017-04-13 15:44 ` [U-Boot] [PATCH 7/8] mips: bmips: fix ioremap for BCM6358 Álvaro Fernández Rojas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6def57db-2f7f-9cd0-8e01-af2d415893f8@gmail.com \
    --to=noltari@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox