U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Padmarao Begari <padmarao.begari@amd.com>, u-boot@lists.denx.de
Cc: git@amd.com, venkatesh.abbarapu@amd.com
Subject: Re: [PATCH] configs: versal: Fix initial stack pointer
Date: Tue, 8 Apr 2025 10:19:08 +0200	[thread overview]
Message-ID: <6f75461d-ff7a-423a-b7cf-b34ccd9759fc@amd.com> (raw)
In-Reply-To: <20250407134544.3951763-1-padmarao.begari@amd.com>



On 4/7/25 15:45, Padmarao Begari wrote:
> The mini u-boot is getting exception because of an initial
> stack pointer address is used at near the top of memory,
> and while executing u-boot is assigned pre-malloc and
> global_data memory after initial stack pointer and updated
> the stack pointer. Serial driver is used pre-malloc area
> for serial operations before relocation. But pre-malloc area
> is cleared while doing BSS at relocation time. The u-boot is
> called board_init() function and doing printf, relocation serial
> driver is not initialized yet, so it is using before relocation
> serial operations but it is cleared by BSS and got the exception.
> To fix, change an initial stack pointer address from near the
> top of memory to near the relocation memory.
> 
> Fixes: 685874939a5e ("configs: versal: update initial stack pointer")
> Signed-off-by: Padmarao Begari <padmarao.begari@amd.com>
> ---
>   configs/xilinx_versal_mini_ospi_defconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/xilinx_versal_mini_ospi_defconfig b/configs/xilinx_versal_mini_ospi_defconfig
> index e1cdc186fb4..af9ce499169 100644
> --- a/configs/xilinx_versal_mini_ospi_defconfig
> +++ b/configs/xilinx_versal_mini_ospi_defconfig
> @@ -7,7 +7,7 @@ CONFIG_SYS_MALLOC_LEN=0x2000
>   CONFIG_SYS_MALLOC_F_LEN=0x500
>   CONFIG_NR_DRAM_BANKS=1
>   CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
> -CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xFFFFFE00
> +CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0xFFFE1000
>   CONFIG_SF_DEFAULT_SPEED=30000000
>   CONFIG_ENV_SIZE=0x80
>   # CONFIG_DM_GPIO is not set

Applied.
M

      reply	other threads:[~2025-04-08  8:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 13:45 [PATCH] configs: versal: Fix initial stack pointer Padmarao Begari
2025-04-08  8:19 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f75461d-ff7a-423a-b7cf-b34ccd9759fc@amd.com \
    --to=michal.simek@amd.com \
    --cc=git@amd.com \
    --cc=padmarao.begari@amd.com \
    --cc=u-boot@lists.denx.de \
    --cc=venkatesh.abbarapu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox