From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/8] FAT: Simplify get_contents
Date: Wed, 5 Sep 2012 00:07:53 +0200 (CEST) [thread overview]
Message-ID: <70666887.3636336.1346796473568.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20120904205034.GC23991@bill-the-cat>
Hi Tom,
On Tuesday, September 4, 2012 10:50:34 PM, Tom Rini wrote:
> On Sun, Sep 02, 2012 at 05:25:20PM +0200, Wolfgang Denk wrote:
> > Dear Beno??t Th??baudeau,
> >
> > In message
> > <1663419836.332713.1342790497668.JavaMail.root@advansee.com> you
> > wrote:
> > > One call to get_cluster can be factorized with another, so avoid
> > > duplicatin> g
> > > code.
> > >
> > > Signed-off-by: Beno??t Th??baudeau
> > > <benoit.thebaudeau@advansee.com>
> > > Cc: Wolfgang Denk <wd@denx.de>
> > > ---
> > > Changes for v2:
> > > - Patch renumbering because of the new v2 1/8.
> > > - Possible code style changes due to the new v2 1/8.
> > >
> > > .../fs/fat/fat.c | 14
> > > +-------------
> > > 1 file changed, 1 insertion(+), 13 deletions(-)
> >
> > Applied, thanks.
>
> OK, this change is NOT equivalent code. My platforms now hang thusly
> (with DEBUG set):
> reading u-boot.img
> VFAT Support enabled
> FAT16, fat_sect: 4, fatlength: 144
> Rootdir begins at cluster: 0, sector: 292, offset: 24800
> Data begins at: 316
> Sector size: 512, cluster size: 4
> FAT read sect=292, clust_size=4, DIRENTSPERBLOCK=16
> Rootvfatname: |u-boot.ais|
> RootMismatch: |u-boot.ais|u-boot.ais|
> RootMismatch: |u-boot.ais||
> RootMismatch: |mlo||
> Rootvfatname: |u-boot.img|
> RootName: u-boot.img, start: 0xc2, size: 0x337d0
> Filesize: 210896 bytes
> 64 bytes
> gc - clustnum: 194, startsect: 1092
> Size: 210896, got: 64
>
> This is all fine in full U-Boot.
OK. I'm looking into it.
Can you give more details, like the type of storage (usb, mmc, etc.)? Do you
have a command line and a disk image that could be used to duplicate the issue?
Best regards,
Beno?t
next prev parent reply other threads:[~2012-09-04 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 22:02 [U-Boot] [PATCH 6/7] FAT: Simplify get_contents Benoît Thébaudeau
2012-07-20 13:21 ` [U-Boot] [PATCH v2 7/8] " Benoît Thébaudeau
2012-09-02 15:25 ` Wolfgang Denk
2012-09-04 20:50 ` Tom Rini
2012-09-04 22:07 ` Benoît Thébaudeau [this message]
2012-09-04 22:10 ` Tom Rini
2012-09-04 22:41 ` Tom Rini
2012-09-04 22:53 ` Benoît Thébaudeau
2012-09-05 0:03 ` Tom Rini
2012-09-04 22:08 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70666887.3636336.1346796473568.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox