From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Date: Tue, 26 Jul 2016 12:03:13 +0530 Subject: [U-Boot] [PATCH 2/4] ARM: dra7xx_evm: Enable support for TI PCF8575 In-Reply-To: <20160725133839.GI14698@bill-the-cat> References: <20160725131023.30656-1-vigneshr@ti.com> <20160725131023.30656-3-vigneshr@ti.com> <20160725133839.GI14698@bill-the-cat> Message-ID: <715c96ff-e364-04bc-b108-38d97a015960@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday 25 July 2016 07:08 PM, Tom Rini wrote: > On Mon, Jul 25, 2016 at 06:40:21PM +0530, Vignesh R wrote: > >> On DRA7, pcf chip present at address 0x21 on i2c1, is used to >> switch between cpsw slave0 and slave1. Hence, enable PCF >> driver for the same. >> >> Signed-off-by: Vignesh R >> --- >> include/configs/dra7xx_evm.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h >> index 0d51aeb86909..4ad8beaf2f75 100644 >> --- a/include/configs/dra7xx_evm.h >> +++ b/include/configs/dra7xx_evm.h >> @@ -328,4 +328,9 @@ >> #define CONFIG_EEPROM_CHIP_ADDRESS 0x50 >> #define CONFIG_EEPROM_BUS_ADDRESS 0 >> >> +/* PCF Support */ >> +#ifndef CONFIG_SPL_BUILD >> +#define CONFIG_PCF8575_GPIO >> +#endif > > We need to invert the logic and undef on SPL, and pick this up normally > via Kconfig. > I tried that initially but, the logic does not seem to work. Since, the driver is DM only driver, undef'ing CONFIG_PCF8575_GPIO on CONFIG_SPL_BUILD does seem to take any effect, the driver is still being compiled for SPL build and results in compile time errors. It seems that undef in include/configs/* file does not seem to take effect in Makefile, but only takes effect in the code. Any idea what am I missing? -- Regards Vignesh