public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] ARM: rmobile: Enable DM capable RCar I2C driver on Lager
Date: Thu, 10 May 2018 12:23:19 +0200	[thread overview]
Message-ID: <71656d79-17f8-2d08-c8f7-eae00b60c49f@gmail.com> (raw)
In-Reply-To: <a44cd0fc-cb74-bf0a-4cbe-93287b73785c@denx.de>

On 05/10/2018 09:23 AM, Heiko Schocher wrote:
> Hello Marek,

Hi,

> Am 01.05.2018 um 09:03 schrieb Marek Vasut:
>> Enable the DM capable driver instead of the legacy one.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>>   configs/lager_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/lager_defconfig b/configs/lager_defconfig
>> index 1071da24d2..7dcd9b7dd8 100644
>> --- a/configs/lager_defconfig
>> +++ b/configs/lager_defconfig
>> @@ -53,6 +53,7 @@ CONFIG_CLK_RENESAS=y
>>   CONFIG_DM_GPIO=y
>>   CONFIG_RCAR_GPIO=y
>>   CONFIG_DM_I2C=y
>> +CONFIG_SYS_I2C_RCAR_I2C=y
>>   CONFIG_SYS_I2C_RCAR_IIC=y
> 
> Isn;t CONFIG_SYS_I2C_RCAR_IIC also a i2c driver?
> 
> Has this SoC 2 different i2c drivers?

Yes :)

> If so, you can add my
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>
> 
> (Also to patch 4)
> 
>>   CONFIG_DM_MMC=y
>>   CONFIG_SH_MMCIF=y
>>
> 
> bye,
> Heiko


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2018-05-10 10:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01  7:03 [U-Boot] [PATCH 1/4] i2c: rcar_i2c: Remove the driver Marek Vasut
2018-05-01  7:03 ` [U-Boot] [PATCH 2/4] i2c: rcar_i2c: Add DM and DT capable I2C driver Marek Vasut
2018-05-10  7:20   ` Heiko Schocher
2018-05-01  7:03 ` [U-Boot] [PATCH 3/4] ARM: rmobile: Enable DM capable RCar I2C driver on Lager Marek Vasut
2018-05-10  7:23   ` Heiko Schocher
2018-05-10 10:23     ` Marek Vasut [this message]
2018-05-01  7:03 ` [U-Boot] [PATCH 4/4] ARM: rmobile: Enable DM capable RCar I2C driver on Silk Marek Vasut
2018-05-08  8:14 ` [U-Boot] [PATCH 1/4] i2c: rcar_i2c: Remove the driver Heiko Schocher
2018-05-08  9:28   ` Marek Vasut
  -- strict thread matches above, loose matches on Subject: below --
2018-05-12 21:15 Marek Vasut
2018-05-12 21:15 ` [U-Boot] [PATCH 3/4] ARM: rmobile: Enable DM capable RCar I2C driver on Lager Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71656d79-17f8-2d08-c8f7-eae00b60c49f@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox