[U-Boot] [PATCH v7 04/19] imx: mx53ard: Add support for NAND Flash

Fabio Estevam
2013-02-26T17:33:46Z

On Tue, Feb 26, 2013 at 1:53 PM, Beno?t Th?baudeau
<benoit.thebaudeau@advansee.com> wrote:

> OK. Please update all boards using mxc_nand.

Yes, will send a patch soon.

>> I was able to read and write to NAND, I have also tested to save env
>> vars into NAND and it works fine.
>
> Great! Thanks for testing.
>
>> So, after changing the IOMUX as per FSL U-boot
>
> If I look at FSL's setup_nfc() vs. my setup_iomux_nand():
> - The IOMUX setup is the same, with CS1 and DA0-7 left in their reset ALT0
> mode.
> - The pad setups differ from the reset values in FSL's code, so I think that
> this is all that needs to be changed (i.e. adding the mxc_iomux_set_pad()).
> Can you confirm?

Yes, correct.

> - Are 'M4IF_GPR.MM = 0' and 'EIM_CSxGCR2[12] = 0' also required, or is this
> handled properly by your board through BOOT_CFG1[6]? I think that we should
> enforce this too by software for the same reason as for bus width.

Yes, we need to enforce this by software. If I skip such settings,
NAND is no longer functional on mx53ard.

>> you can add my:
>> Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Will do, thanks again. So for 01-03, and 15 (with 0x32000). Do you agree?

Yes, correct.

Very good job you did, thanks!