public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Tom Rini <trini@konsulko.com>, u-boot@lists.denx.de
Cc: Jerome Forissier <jerome.forissier@linaro.org>
Subject: Re: [PATCH] doc/develop/sending_patches.rst: Clarify when to use which branch
Date: Mon, 26 Aug 2024 18:46:29 +0200	[thread overview]
Message-ID: <71e211ae-4acc-4a0b-9014-dfe35a2d74cf@cherry.de> (raw)
In-Reply-To: <20240826163917.2786791-1-trini@konsulko.com>

Hi Tom,

On 8/26/24 6:39 PM, Tom Rini wrote:
> The previous wording on the paragraph about what branch to use when
> submitting patches did not reflect how / when the next branch is
> currently used. Reword this to note that master should be used for bug
> and regression fixes, always, and that next should be used once it
> opens, with -rc2.
> 
> Reported-by: Jerome Forissier <jerome.forissier@linaro.org>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>   doc/develop/sending_patches.rst | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/doc/develop/sending_patches.rst b/doc/develop/sending_patches.rst
> index 3f25b1d0466f..82efb717b179 100644
> --- a/doc/develop/sending_patches.rst
> +++ b/doc/develop/sending_patches.rst
> @@ -74,11 +74,13 @@ General Patch Submission Rules
>   
>   * Send your patches as plain text messages: no HTML, no MIME, no links, no
>     compression, no attachments. Just plain text. The best way the generate
> -  patches is by using the ``git format-patch`` command. Please use the
> -  ``master`` branch of the mainline U-Boot git repository
> -  (``https://source.denx.de/u-boot/u-boot.git``) as reference, unless (usually
> -  late in a release cycle) there has been an announcement to use the ``next``
> -  branch of this repository instead.
> +  patches is by using the ``git format-patch`` command. For a patch that is
> +  fixing a bug or regression of some sort, please use the ``master`` branch of
> +  the mainline U-Boot git repository
> +  (``https://source.denx.de/u-boot/u-boot.git``) as reference. For new

Please also remove the tick quotes around the link, it means we cannot 
click on it anymore as it's basically "verbatim". Maybe in a separate patch?

Looks good to me otherwise,

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

  reply	other threads:[~2024-08-26 16:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 16:39 [PATCH] doc/develop/sending_patches.rst: Clarify when to use which branch Tom Rini
2024-08-26 16:46 ` Quentin Schulz [this message]
2024-08-26 17:01 ` [PATCH] doc/develop/sending_patches.rst: Reword where our git tree is slightly Tom Rini
2024-08-27 10:02   ` Quentin Schulz
2024-08-27 13:03   ` neil.armstrong
2024-08-26 17:27 ` [PATCH] doc/develop/sending_patches.rst: Clarify when to use which branch Jerome Forissier
2024-09-15 17:00 ` Heinrich Schuchardt
2024-09-15 18:19   ` Tom Rini
2024-09-15 18:23     ` Tom Rini
2024-09-15 18:25   ` Tom Rini
2024-09-16 20:41 ` (subset) " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71e211ae-4acc-4a0b-9014-dfe35a2d74cf@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=jerome.forissier@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox