[U-Boot] [PATCH] fsl_esdhc: Add no-snoop config for default init

Stefano Babic
2012-08-11T10:43:21Z

On 10/08/2012 23:13, Beno?t Th?baudeau wrote:
> cfg->no_snoop was available only through custom fsl_esdhc_mmc init functions.
> Add a config options to make it available also through the default init.
>

Hi Beno?t,

> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> Cc: Andy Fleming <afleming@gmail.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Kim Phillips <kim.phillips@freescale.com>
> ---
> .../drivers/mmc/fsl_esdhc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git u-boot-4d3c95f.orig/drivers/mmc/fsl_esdhc.c u-boot-4d3c95f/drivers/mmc/fsl_esdhc.c
> index b6c969d..21154e5 100644
> --- u-boot-4d3c95f.orig/drivers/mmc/fsl_esdhc.c
> +++ u-boot-4d3c95f/drivers/mmc/fsl_esdhc.c
> @@ -597,6 +597,9 @@ int fsl_esdhc_mmc_init(bd_t *bis)
> cfg = malloc(sizeof(struct fsl_esdhc_cfg));
> memset(cfg, 0, sizeof(struct fsl_esdhc_cfg));
> cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
> +#ifdef CONFIG_SYS_FSL_ESDHC_NO_SNOOP
> + cfg->no_snoop = 1;
> +#endif
> return fsl_esdhc_initialize(bis, cfg);
> }
>

Using a structure to setup the controller avoids to add further CONFIG_
switch. I do not find the needs to have both. Why do you need ?

Best regards,
Stefano Babic

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================