[U-Boot] [PATCH] fsl_esdhc: Add no-snoop config for default init

Benoît Thébaudeau
2012-08-12T13:52:00Z

Hi Stefano,

On 08/12/2012 8:25, Stefano Babic wrote:
> On 11/08/2012 19:59, Beno?t Th?baudeau wrote:
>
> Hi Beno?t,
>
> > That could be a solution. However, that would have to be done for
> > i.MX25 and
> > i.MX35 too (I have patches to add/fix eSDHC support for these that
> > I will post
> > shortly), which means more duplicated code that should rather be
> > centralized
> > somewhere.
>
> can I ask you which kind of problems you have seen on a i.MX35 ? I
> was
> curious after your e-amil and I enabled the FSL_ESDHC driver on a
> mx35pdk - it seems working out of the box, I have not changed the
> driver.

Yes, it's not a big deal. The driver itself is fine. The issues are clock and
init issues in the mx25- and mx35-specific files (clock.c, generic.c and the
associated headers I think). I don't remember precisely what applied to mx25
and/or mx35, but what I fixed is:
- init code referring to mxc mmc instead of fsl esdhc,
- wrong handling of the cpu_mmc_init return value in some cases,
- wrong source clock reported to the fsl_esdhc driver (not the eSDHC clock, and
not making any difference between the clocks of the various eSDHC instances), so
that if it works it's only by chance, and the actual SD clock will likely be
different from what mmcinfo reports, depending on the selected board clock
dividers.

Best regards,
Beno?t