[U-Boot] [PATCH 2/2] fsl_esdhc: Remove cache snooping for i.MX

Stefano Babic
2012-08-13T15:16:14Z

On 13/08/2012 16:39, Beno?t Th?baudeau wrote:

>>
>> Why don't you get rid of no_snoop at all ? Using ARCH_IMX is not
>> needed
>> anymore.
>
> Because I didn't know if disabling cache snooping could be a useful option or
> not for architectures other than i.MX, so I preferred to leave it just in case,
> even if it seems to be unused.

I introduce no_snoop when I adapted the driver for iMX. I do not see
PowerPC boards setting this bit.

And checking this, it seems to me that code in
arch/arm/cpu/armv7/imx-common/cpu.c is wrong, because cpu_mmc_init()
does not set the bit and the scr register is set (or could be set) even
for i.MX6 SOCs. Maybe writing at this adress does not cause problems,
but it seems wrong. You patch then fixes also this issue.

> But if you are certain that disabling cache snooping can not be useful for
> architectures other than i.MX (now or in the future, for boards in or out of
> tree), I can completely remove no_snoop. Just tell me.

IMHO you can drop it.

>
> Perhaps you have a rule such as "remove any stuff that is unused in mainstream".

It would be nice to have it ;-)

Best regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================