From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FC17C77B72 for ; Fri, 14 Apr 2023 13:52:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7579C85DEA; Fri, 14 Apr 2023 15:52:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="q5er/1lU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D29E785CB1; Fri, 14 Apr 2023 15:52:29 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on20607.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5b::607]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4707385CB1 for ; Fri, 14 Apr 2023 15:52:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ILZH3GVvDBazvk98WJC5lPfPVkrEnqdnb81bfwoSS6h48B0G+A4YI5ISmrVmrVaaK3a1X+1bFhEWQ8N66zlJrrx69QUwbh04JhSdknvtAZciGVpCQxPgwi/No588nqiBOkDv7TLRQK+fSy08NUZHYej4gQcXmCmDyLnX2btOZMIkUvT4J3zI6PqDb9HYyOB1WeOlX/mR43qZ2PSPf3N9QdgIRmg8+y8DhVmZYgMLHoVQProu93T0ZQZNcTYN6Nm8rpzwkh2oHs01vSva/ZP/tNzPoYB9hPdrh45LPA+nOQ58ZKPKTNC4Z0ctwNrmteg+UnFuKYfa8V6XAGV5wE6v8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XBu2IHzjpb9Afd9B/tQEqvFZjbwaZW4WbO3vNDQ32X8=; b=hJ7vbWEFh8AEqqu6ehVoz9b6X/ej20n4dhOQAwg7/JWlvkv+KSRMIVuEvJUXqu0UOa9teTvxiJS/F4DV0nw5fpuONoMcQy5130BFDMVC5w1wczTKYcr0Xo/Af+fByHJg0RNzoTZWfjSMa5YZJo6B6oUQTcu70mS7+ZKiSzF1QWWK4NW2DiMvZiGDyHoWuSkS3OsA/8yQ7CYmsTbt/IFOQE5G6w7yEmvMnxaWnnGJ+wfsKsx3xMSXPWUfdlL8z9p3dpDS5K8EySqJmnylQjn03JTb29w55NrZfvK+juOwbrV3QObMzBAE88/2la5p5f+uljgJ6TGgX27ns0JIhZs+ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XBu2IHzjpb9Afd9B/tQEqvFZjbwaZW4WbO3vNDQ32X8=; b=q5er/1lUYKIV3f/H317N2O963IFBkVcC3zVs7LnsiLQlTDmi2eksZaTquAG7n9INCWYdM19qCYdEkttzRWv1suLr8x6tvry5yTOcukWzlpJRQJATJPpd8bhM/8GUamaYkEaJ3epfhDegLXo/qQfLqZ3Oso3ywBM0T3swgK+QXqY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by DM6PR12MB4284.namprd12.prod.outlook.com (2603:10b6:5:21a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.30; Fri, 14 Apr 2023 13:52:22 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::4d07:7f52:c833:9603]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::4d07:7f52:c833:9603%6]) with mapi id 15.20.6277.038; Fri, 14 Apr 2023 13:52:22 +0000 Message-ID: <748fabc8-deef-a921-e99b-0f62769a5853@amd.com> Date: Fri, 14 Apr 2023 15:52:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 6/6] fwu: DeveloperBox: add support for FWU Content-Language: en-US To: Jassi Brar Cc: jassisinghbrar@gmail.com, u-boot@lists.denx.de, ilias.apalodimas@linaro.org, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, sughosh.ganu@linaro.org, xypron.glpk@gmx.de, takahiro.akashi@linaro.org References: <20230327211458.498879-1-jaswinder.singh@linaro.org> <20230327211640.499001-1-jaswinder.singh@linaro.org> From: Michal Simek In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0401CA0004.eurprd04.prod.outlook.com (2603:10a6:800:4a::14) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|DM6PR12MB4284:EE_ X-MS-Office365-Filtering-Correlation-Id: 98d5ae2b-f515-4595-7003-08db3cef78da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p0FFRR/aiaTpOB+/m+hvEneZvgoSAM1L3Vf+X/q/NG+7o4NAPanYFIfXqIRX4QGUsuYpLyhK7WLKMKxOqbXWqyafzk/z/dn0/Bz7DMgpXbZeKLEZM2rDEvYDnF63tvs46bneTlBhO/KZ40z0kft44b6ILy81UfuTnlfS5SW0+KKvDpkF1WgSMm2lowagtJTAjZTIKkqX7gGnsQDzT52ewAubF1qZbCn7/FsYuccL7+J2AczA7kE2+q8dJI6ra6XmLvyb51kF2RsDeQAbqyyRcwYvS8pE3XgOEi+Wpfp/CPx5/eBRhhjx0WoQqDsq2xc0+U6VFMndOMDd1LFvED7rTCWlVQB43tdRiYN1e/2nlSpvMEhFiY4pRrK7BgeI0Gqjcee3QYuvJFzAjJrXaqRdnUvNNfBZ3I/C9TbgnvxvP92BAv61bpqLIDcT30AfVa32GmB+lJ9MGFe6vk71fEbdh8l8dLSiELYZbkY4LSoPBrlm2vivmEW5X4mnM0MQIBwoQ0dkb/hA48k3ANYu3L2YvxahCTs8vZYLGR2kJMVNlIyVAxJ+IIKXcoFvptG+4/N8ZpAxkXsCc4Gu99SVLOTIut1nnZWxIanBdL6FQwPid+RWHXebV/h2BO0r3ybG6dOcldWg6pTI1bWTTmQDh5Etaw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(396003)(376002)(39860400002)(366004)(451199021)(31686004)(83380400001)(26005)(186003)(38100700002)(6666004)(6916009)(66556008)(31696002)(316002)(6486002)(66476007)(4326008)(36756003)(86362001)(478600001)(66946007)(41300700001)(7416002)(53546011)(6512007)(6506007)(8936002)(8676002)(5660300002)(2616005)(44832011)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1hPZUhCMlJFaXh1WU1zeW1pQjRwWHVMYm50T0lrNmN4UENZRzlHeWxubmw4?= =?utf-8?B?NzM4MGNVN0NhTmtmSFEycEtiZThXV3NHQ1pXb1A3bzZmclhRNm1qT0ZNTnpj?= =?utf-8?B?UVkzYU9lV21QaDJBeVVFaHFkb2VpNUp5THlJemZxYXpzTTVVQys5cEZld0p1?= =?utf-8?B?VUZxNk5kcjZOZldyQjcyQkE4aDZmendKNFk3RUdkVVMzTzh1WSswM245eFAw?= =?utf-8?B?bGUxT0ZyUkxyZUl4Z2lIanRaN2ZrL0JWYjJhRXgyODFxeXh4aWFXNm03WlBJ?= =?utf-8?B?L29VY1pRd3pEaGNUaTJkT1M1cW55a1NVaDdFNUlHVURMODM1ay9nQldGcE91?= =?utf-8?B?ek8vcUJHVXZkYS9yNGFzcHRqeEw3azNqZ0JXOWFaeDM3ZGhzaEU1QmZuRnpW?= =?utf-8?B?RldRNnQ3OUpHQmphekgxaWZWL1pIZlpIOElrd0JJcFhrME82dWtEOXZJVHdH?= =?utf-8?B?T0F6WkdqZU84ckpKd2pxdG1sMlN4UldRQnNDSk9YSmIzTVBwdDdoNWEwWEZs?= =?utf-8?B?bCtmemdjdTN4d0xNdHZMdjVSNTFEK3ZiRXFvek9CNGY0enpDQ3JuK3hlQ21W?= =?utf-8?B?Uzk3S0IrRXZ4Z0dLYnk3a3g4d2wwZmJZdnNpZmxHaDNvM0REdGxGTThBSFQ3?= =?utf-8?B?S0hwMlBBektrUGJ2M0hYdjVMbFgxZ1ExSjVPVU1MbzdUNEhod1FIdThhV3dJ?= =?utf-8?B?VzQ2SzhaRFlBbHVndXM3aEIyLzdYaDFjd3p3SHkyUUloMEk4blJlSkcwUGVv?= =?utf-8?B?Y2FJdGFRdXVlUHZjT2gzS21BN0NNTXZwZGJ5bTNOODRvSzlFN1pyV2pNQjg2?= =?utf-8?B?eGduTUErUjcxM3lsaVJ6VHFqVTYrWnhIdFZkck5OTk5EOVhqSFBvQmpCZEdZ?= =?utf-8?B?cmVJKzIyNnBXYTNVZzFjVDRJYm1JTmR1MHJVZEh0ai9MNEJsaGRlL2tsYisx?= =?utf-8?B?cVI0eWUvc2QxUXBEK2ZhTEVoL3JJK0RCdmU5Zy9sWWhtUG84cWdTeFNDczUr?= =?utf-8?B?TnB2aFZhbnE3cklmZGhvbjNidmxiR0gzU1dFT2IwN0NLU2dGMHZqYXpFWnRu?= =?utf-8?B?T0oxUUJxL1NwM0RyVDFjK0dmNUJtamhIemNEMjRaSUlNWFNZVUZzQUF3Ly8y?= =?utf-8?B?RTRSemlNdFVoVW9PcDN0aytmbVhSK3RWS0hTVjdPMWYrYlU2UVQ0enQ5U3Yw?= =?utf-8?B?RUtBM2tLcm9ERVFKQzRYbk1DM2R1RHJTL28vNVpadHRpZWF6TVIrQlk3cjZi?= =?utf-8?B?cFQrVkxiaDhzTmhKa0liK1F0YkhtUjl4NFpJUHZOMmw1MmlvU0ZIWkRNcU1J?= =?utf-8?B?UVNvckRQUWE4VCtnZVhEbU5ndityT3BoaUJWcmVzeVJ4eEJPTjkreVpuWGky?= =?utf-8?B?QVhEYmd6WHdpcDh5aU9zR3R2eE1zQ3p4SS9QL2pGQ1JTTTVjSWIveUhGK3pu?= =?utf-8?B?dUpGYklnV3NFd2RpUzZpeW5tenBuck5zM1ExdWYwT0I0bkpoY3g3UVkwcGEw?= =?utf-8?B?dnJUdnY3emhyc3BNREVFZ3NZZHUzRDJKVU81ejZwR0Y2R01NRmdnN2Zmcm9T?= =?utf-8?B?UXBkUlB4TmNnVW44VXVpL3lJQXVHcTF3N0phcXBodkQzOEtKSHk4NlRrR1F0?= =?utf-8?B?YUNHUUJuVitRYVFCd3ZVdm44emNJcW1PT21qd3ZybEVKSVZHdVUxbTIwMVRO?= =?utf-8?B?eUpqKyt3SGdkVkdsTy9CZWlQZnBROUU2Qm1ITW90ZEM3T2drVWlyTk9pUmtL?= =?utf-8?B?UmYxNDAyaGhmT2ZOQ3JYN0Z0eXFSZDdPS1hmSlFzQVc3c0VjVlhZZDVEdVFi?= =?utf-8?B?b0JaR0FuVTEzbVhUSS9xRkZhM2tHVkRmOUFUTVRIdlpBcUNnWFAyeG9VWTJG?= =?utf-8?B?cFpKbTYzQUVCZExGbmRrN010T3NaUTIrRzJPWWtLL1hTYXdqSElxNGZmdm9T?= =?utf-8?B?YUd4VDlHU0RpL01IUTllaDVQQjI5QVd0Z0FqUUVnS2VPSlhmbzAyY1NwcVo3?= =?utf-8?B?d05KcVBWNUZaZmNRMEVXeFF2TGlJZGVDUnA3d1o4dXhuemxYQmpsOUFXNll4?= =?utf-8?B?Ym53aHF4b1p2NDVPdmtEdWdOcHIzL0dUYmNyc3NYNGJ0RkJNK2gycmlDMkRI?= =?utf-8?Q?wv+SGiC/OBZephaf5ZRAA7nKZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98d5ae2b-f515-4595-7003-08db3cef78da X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2023 13:52:22.8107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e6+eUMWPMORtwYkpWmBE4/0kKL6OJjD/zopr2CPBqhpaJaHZWxii181DflJ+WGI9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4284 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/10/23 06:21, Jassi Brar wrote: > On Wed, 29 Mar 2023 at 08:02, Michal Simek wrote: >> On 3/27/23 23:16, jassisinghbrar@gmail.com wrote: > > ..... >>> + >>> +void fwu_plat_get_bootidx(uint *boot_idx) >>> +{ >>> + int ret; >>> + u32 active_idx; >>> + u32 *bootidx = boot_idx; >>> + >>> + ret = fwu_get_active_index(&active_idx); >>> + >> >> nit: remove this newline >> > ok > >>> + if (ret < 0) >>> + *bootidx = -1; >>> + >>> + *bootidx = active_idx; >> >> Is this logic here right? >> If fwu_get_active_index fails you setup bootidx to -1 >> and right after it you rewrite it to active_idx initialized in >> fwu_get_active_index() to mdata->active_index. >> >> It means why to do *bootidx = -1; at all? >> > yes :) it's a silly remnant of history of changes. > Actually this goes away after implementing the default/weak function. > > >>> +} >>> diff --git a/configs/synquacer_developerbox_defconfig b/configs/synquacer_developerbox_defconfig >>> index 09e12b739b..d09684153a 100644 >>> --- a/configs/synquacer_developerbox_defconfig >>> +++ b/configs/synquacer_developerbox_defconfig >>> @@ -97,3 +97,11 @@ CONFIG_EFI_RUNTIME_UPDATE_CAPSULE=y >>> CONFIG_EFI_CAPSULE_ON_DISK=y >>> CONFIG_EFI_IGNORE_OSINDICATIONS=y >>> CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y >>> +CONFIG_EFI_SECURE_BOOT=y >>> +CONFIG_FWU_MULTI_BANK_UPDATE=y >>> +CONFIG_FWU_MDATA=y >>> +CONFIG_FWU_MDATA_MTD=y >>> +CONFIG_FWU_NUM_BANKS=2 >>> +CONFIG_FWU_NUM_IMAGES_PER_BANK=1 >>> +CONFIG_CMD_FWU_METADATA=y >>> +CONFIG_TOOLS_MKFWUMDATA=y >> >> doesn't look like that it was created via savedefconfig. >> > Yes. I had some other config changes too and picked only the relevant > ones together. But this is defconfig not documentation. > > >>> +And make a FIP image.:: >>> + >>> + cp build/synquacer/release/fip.bin SPI_NOR_NEWFIP.fd >>> + tools/fiptool/fiptool update --tb-fw build/synquacer/release/bl2.bin SPI_NOR_NEWFIP.fd >>> + >>> +UUIDs for the FWU Multi Bank Update >>> +----------------------------------- >>> + >>> +FWU multi-bank update requires some UUIDs. The DeveloperBox platform uses >>> +following UUIDs. >>> + >>> + - Location UUID for the FIP image: 17e86d77-41f9-4fd7-87ec-a55df9842de5 >> >> >> In past you have it listed at flash node in DT. I see you have removed it >> between v3 and v4 without any note about it. >> Is it still needed? And should it be listed in DT spec again? >> > After the dt change, we no longer require this. But the location_uuid > is a standard member of an fwu_image_entry and cmd/fwu_mdata.c always > print it. So I think this should be seen as just what a platform wants > some unique id to be printed for the image (?). I am fine with your explanation but documentation should make this clear that uuid is required by spec but not actually used by current implementation or description. M