From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Date: Wed, 14 Jun 2017 14:35:00 +0530 Subject: [U-Boot] [PATCH v2 01/13] drivers: usb: dwc3: remove devm_zalloc from linux_compact In-Reply-To: <60a58c71-7e11-af94-3620-9ff5c4ef26d6@denx.de> References: <20170613121009.25860-1-vigneshr@ti.com> <20170613121009.25860-2-vigneshr@ti.com> <60a58c71-7e11-af94-3620-9ff5c4ef26d6@denx.de> Message-ID: <74a5cdee-dc19-628d-cd96-dbe611dd41fb@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 13 June 2017 07:28 PM, Marek Vasut wrote: > On 06/13/2017 02:09 PM, Vignesh R wrote: >> From: Mugunthan V N >> >> devm_zalloc() is already defined in dm/device.h header, so >> devm_zalloc can be removed from linux_compact.h beader file. > > Shouldn't it be left in linux_compat.h instead ? linux-compat.h is local to dwc3 folder where as dm/device.h is available globally. My understanding is linux-compat.h is to define functions/wrappers needed by dwc3 part picked from linux that are not yet directly available in U-Boot. But, given that devm_kzalloc() is provided in U-Boot, I thought it would be better to get rid of definition in linux-compat.h in order to avoid conflicting definition error. Regards Vignesh