From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5824C43334 for ; Wed, 6 Jul 2022 16:34:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6C03B8454A; Wed, 6 Jul 2022 18:34:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Sk5/YOtV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A3FC8452D; Wed, 6 Jul 2022 18:34:16 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F0FB68436C; Wed, 6 Jul 2022 18:34:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mr.bossman075@gmail.com Received: by mail-qk1-x736.google.com with SMTP id b125so11417169qkg.11; Wed, 06 Jul 2022 09:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=GVF8Z2lL1+z5+Vi+l1d3NN2hx3E4ylvvIiStKbfjT6M=; b=Sk5/YOtVBGcI8DE5Vf3DjSpjMnb6Oa70RgxqUWejyfOeezFPzAjUBjaAekxfDdCh12 VWT0dohPVq7GSQK8r6HS5Ka8AC696GuSSFRRpyg+SnwvZb/1FDwREFwTcWWfrQ3jov+U K5mT0iqf2+GhcioNRWTeu8QFlK7cbdmRc7efKYbGgzm78777IeSxEe/VEgGetVzLoS9C 1Elk1Ux/bdzVp3Zq9xJGGIyk13mZ15vcM2tKZpp5iKi/AAXlMqcNlhBDW3DQ7dcAtSxP ak+c0IxuhIQZGfwdtoO5nsIQEVDqfFLEKFovXJX2gOR8aC8wk8KcMa4dk9UlTJE4Msm8 uLow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GVF8Z2lL1+z5+Vi+l1d3NN2hx3E4ylvvIiStKbfjT6M=; b=1mA4ZlWTFV4XluS+3c+OYjWmNwGZIF23B4LdEN4QNEVLfHk0dIZozjGVf7mFxqH/qC N/SJTol1OvjA+3v6CpcezeaZd/1KLDK6FolCnvYST/W5eatqRiISHvdBOszcvlqotfRP DYKSCww998KtXagaCjPjeQBCns0vNis1Ijfisja6/4SzU61UCjrCOfWQiqT8IW6drEXU CwD7NCm6cobFPG8jp2r5M9lpni9U8YPUc1FSAohNaxtwaNqDf4CCtONql7qj1M6hqzAK /ZFdwS066hgUtpbVqjf9Nx+k4vQScJBxlk5vFNdrUHKvlrgx+SHDaRkTRG+j3LhCUM7M O1rw== X-Gm-Message-State: AJIora9ycF/g2VuSWz8vRYHYo9vYPvcQrvlUJhDmApY9NOAVF8aMapzS XsV1jBvJ1ukrIkQxao2fbcM= X-Google-Smtp-Source: AGRyM1t+4uqSDpXRc8QWiQyFaCGFW0iKfqTI+Q4m4V7B7cUppkBPh8BnoJqbZciJdrASqDRj8HwZxg== X-Received: by 2002:a37:449:0:b0:6af:3802:e90b with SMTP id 70-20020a370449000000b006af3802e90bmr26820324qke.206.1657125251563; Wed, 06 Jul 2022 09:34:11 -0700 (PDT) Received: from [10.4.10.38] (146-115-144-188.s4282.c3-0.nwt-cbr1.sbo-nwt.ma.cable.rcncustomer.com. [146.115.144.188]) by smtp.gmail.com with ESMTPSA id u16-20020a05620a431000b006a7284e5741sm30752661qko.54.2022.07.06.09.34.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 09:34:10 -0700 (PDT) Message-ID: <74e0ef2e-9569-eef5-6480-0c10fca20e6e@gmail.com> Date: Wed, 6 Jul 2022 12:34:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [ANN] U-Boot v2022.01-rc3 released Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de, u-boot-custodians@lists.denx.de, u-boot-board-maintainers@lists.denx.de, Giulio Benetti , Simon Glass References: <20211129162831.GR24579@bill-the-cat> <14fdf0d7-59b5-83b3-b36d-86c529d04f28@gmail.com> <20211130193625.GN24579@bill-the-cat> <42a47af6-67e0-31d8-ba24-9f1822eeac6f@gmail.com> <20220706144720.GZ1146598@bill-the-cat> From: Jesse Taube In-Reply-To: <20220706144720.GZ1146598@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 7/6/22 10:47, Tom Rini wrote: > On Wed, Jul 06, 2022 at 10:31:41AM -0400, Jesse Taube wrote: >> >> >> On 11/30/21 14:36, Tom Rini wrote: >>> On Mon, Nov 29, 2021 at 09:35:52PM -0500, Jesse Taube wrote: >>>> >>>> >>>> On 11/29/21 11:28, Tom Rini wrote: >>>>> Hey all, >>>>> >>>>> It's been two weeks since v2022.01-rc2, so here's -rc3. >>>>> >>>>> To repeat what I said with -rc2, we've enabled issue tracking on our >>>>> gitlab instance. You can sign up and then be able to file issues at: >>>>> https://source.denx.de/groups/u-boot/-/issues >>>>> >>>>> This is intended for everyone to be able to use, both custodians for >>>>> their own needs (you can see for example Heinrich has filed something >>>>> for UEFI and LMB) as well as users to just report bugs so they don't >>>>> feel like they're lost in the mailing list. >>>>> >>>>> As noted with the last release, the -next branch is open and I'll sync >>>>> in -rc3 shortly. Please feel free to get a PR ready now if you're able. >>>>> >>>>> In terms of a changelog, >>>>> git log --merges v2022.01-rc2..v2022.01-rc3 >>>>> contains what I've pulled but as always, better PR messages and tags >>>>> will provide better results here. >>>>> >>>>> So we're now looking at regular releases every other Monday, and with >>>>> final release on January 10th, 2022. Thanks all! >>>>> >>>> Hey tom, >>>> >>>> Thank you for the update as always! >>>> >>>> I have a question about a recent commit, I hope its okay to ask here. >>>> In commit cd82f199852d88218e1f17f5ec07cdd9112a89c4 >>>> In arch/arm/lib/relocate.S:81 on my SBC it returns an invalid value. >>>> My soc is Thumb2 but the instruction `adr r3, relocate_code` >>>> assembles to `subw r3, pc, #3` which is not 32bit aligned. If i change the >>>> instruction to `adr.w r3, relocate_code` it evaluates to `subw r3, pc, #4`, >>>> which is. >>>> >>>> There is a slight problem as it seems to work fine on my laptop using Debian >>>> bullseye, but on my Desktop where I found this I'm running sid. >>>> They are both gcc-10. I have yet to find a way to consistently replicate it. >>>> >>>> What are your thoughts of this? >>> >>> It sounds like you have enough details here to file a bug with Debian >>> and see where that leads. >>> >> Sorry for replying to old messages but the bug has appeared again in a >> separate case the bug seems to be introduced in >> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d3e52e120b68bf19552743fbc078e0a759f48cb7 >> >> The test code is as follows >> ``` >> .syntax unified >> >> .global bug; >> >> .align 4 >> >> bug: >> >> adr r3, bug >> >> .size bug, .-bug >> >> .type bug 2; // This changes offset from 4 to 3 in >> include/linux/linkage.h:ENDPROC >> //arm-linux-gnueabi-as -march=armv7-m -c -o bug.o bug.S && >> arm-linux-gnueabi-objdump --disassemble=bug bug.o >> ``` >> Releases >2.37 have this issue and causes some arm platforms in u-boot at >> /arch/arm/lib/relocate.S:81 adr r3, relocate_code >> >> I'm wondering if there should be a mitigation for this till binutils is >> patched. > > Thanks for being persistent on this. What would a mitigation look like? > Other people have suggested to use `subw r3, pc, #4` and ifdef for different variants. We could also do `adr.w`, what do you recommend. Unfortunately I'm not very familiar with arm asm so I was just putting it out there because many here know more. I'll continue to look into fixes for u-boot. And look into fixes for binutils as 2.37 is now in buildroot and other tool and distros. I'm not sure if line 81 is the only one that is affected but if it is then its a much easier fix than every adr instruction. Thanks, Jesse