From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Dubov <oakad@yahoo.com>
Date: Mon, 27 Dec 2010 20:42:33 -0800 (PST)
Subject: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer
	Systems MPQ101 board
In-Reply-To: <20101227121222.D1324152438@gemini.denx.de>
Message-ID: <754013.38475.qm@web37602.mail.mud.yahoo.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> > +phys_size_t
> > +initdram (int board_type)
> > +{
> ...
> > +??? dram_size = setup_ddr_tlbs(1ull
> << (CONFIG_SYS_SDRAM_SIZE_LOG - 20));
> > +
> > +??? puts("? ? DDR: ");
> > +
> > +??? return dram_size << 20;
> 
> You should use get_ram_size().

I still need to call setup_ddr_tlbs because get_ram_size won't do it for
me. So what get_ram_size actually does?


> > +??? lbc->lcrr |= 0x00030000;
> > +??? asm("sync;isync;msync");
> > +
> > +??? lbc->ltesr = 0xffffffff;?
> ? ? ? /* Clear LBC error interrupts */
> > +??? lbc->lteir = 0xffffffff;?
> ? ? ? /* Enable LBC error interrupts */
> 
> NAK.? Please use proper I/O accessors.

Do you mean out_be32 and friends?
In which case, why are not these used when writing config values to DDR
registers (for instance) even in some very recently added boards, such as
p2020ds?

> 
> ...
> > +#define
> CONFIG_SYS_LOAD_ADDR???0x2000000? ?
> ???/* default load address */
> ...
> > +#define CONFIG_LOADADDR? 1000000 /*default
> location for tftp and bootm*/
> 
> You probably want to make this consistent.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,? ???MD:
> Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194
> Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email:
> wd at denx.de
> You can only live once, but if you do it right, once is
> enough.
>