Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup

Steve Bennett
2021-07-05T05:08:14Z

On 4 Jul 2021, at 5:26 am, Wolfgang Denk <wd@denx.de> wrote:
>
> Dear Sean,
>
> In message <d3a91238-db2f-edbe-ecec-ddb5dc848ed7@gmail.com> you wrote:
>>
>> Well, since Hush was never updated, I don't believe LIL will be either.
>
> Let's please be exact here: Hus has never been updated _in_U-Boot_,
> but it has seen a lot of changes upstream, which apparently fix all
> the issues that motivated you to look for a replacement.
>
>> I think reducing the amount of ifdefs makes the code substantially
>> easier to maintain. My intention is to just use LIL as a starting point
>> which can be modified as needed to better suit U-Boot.
>>
>> The other half of this is that LIL is not particularly actively
>> developed. I believe the author sees his work as essentially
>> feature-complete, so I expect no major features which we might like to
>> backport.
>
> This sounds like an advantage, indeed, but then you can also
> interpret this as betting on a dead horse...

My 2c on this.

I am the maintainer of JimTcl (and I agree it is too big to be considered a candidate).
LIL source code has almost zero comments, poor error checking and no test suite.
I would be very hesitant to adopt it in u-boot without serious work.

I would much rather see effort put into updating hush to upstream.
My guess is that Denys would be amenable to small changes to make it easier to synchronise
with busybox in the future.

Cheers,
Steve