[U-Boot] [PATCH] ARM: dts: rmobile: Zap redundant USB/SDHI nodes on M3N

Eugeniu Rosca
2019-03-07T19:20:05Z

Hi Marek,

On Thu, Mar 07, 2019 at 01:53:29AM +0100, Marek Vasut wrote:
> On 3/6/19 6:55 PM, Eugeniu Rosca wrote:
> > v2019.01 commit cbff9f80cedd ("ARM: dts: rmobile: Sync Gen3 DTs with
> > Linux 4.19.6") made the sdhi/usb nodes available in r8a77965.dtsi.
> >
> > Hence, remove the SDHI/USB nodes from r8a77965-u-boot.dtsi. This is
> > equivalent to partially reverting below v2019.01 commits:
> > - f529bc551b6d ("ARM: dts: rmobile: Extract USB nodes on M3N")
> > - 830b94f76867 ("ARM: dts: rmobile: Extract SDHI nodes on M3N")
> >
> > Not doing that results in MMC devices being undetected on M3NULCB:
>
> M3N ULCB is not supported yet, so how can this be broken ?

My description is not about the mainline status of M3NULCB, but rather
about why the patch was sent to you. Most likely the same issue occurs
on r8a77965-salvator-x{s} (which I don't have at hand), since their DTS
also include r8a77965-u-boot.dtsi.

Common sense tells that you should not factor out DT nodes to
<soc>_u-boot.dtsi when they are properly defined and supported in
<soc>.dtsi, so may I hope for a second review?

> I am planning to add support for it [1], however that is work in
> progress and the patches still need more work. Can you rebase your
> changes on top of that branch and if you have M3N ULCB, test it ?
> The branch also contains sync with Linux 5.0 DTs, however it is also
> work in progress and there's likely to be breakage.

Unfortunately, [1] doesn't compile [2].

What I can tell you is that running rcar-3.9.3.rc1 U-Boot on M3NULCB
results in:

* w/o the fix:
=> mmc list
No MMC device available

* with the fix:
=> mmc list
sd at ee100000: 0
sd at ee140000: 1 (eMMC)

Your branch [1] doesn't touch arch/arm/dts/r8a77965-u-boot.dtsi, so I
expect it exhibits the same issue as Renesas RC [3].

> [1] https://github.com/marex/u-boot-sh/tree/m3nulcb-v1
[2] https://gist.github.com/erosca/9d2dd0ea16fb9f208effc89226e2b27f
[3] https://github.com/renesas-rcar/u-boot/tree/v2018.09/rcar-3.9.3.rc1

Thanks,
Eugeniu.