From: Tirumala Marri <tmarri@apm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support
Date: Thu, 9 Sep 2010 09:43:31 -0700 [thread overview]
Message-ID: <761e2a44969fc6900a6e773118255351@mail.gmail.com> (raw)
In-Reply-To: <20100909145320.AD2B81506AA@gemini.denx.de>
> > > include/apm821xx.h | 493
> +++++++++++++++++++++++++++++++
> >
> > I know that Wolfgang specifically asked you to add this file for this
> > "new" SoC. But I'm not so sure if this is the right way. Most of the
> > defines in this new file are a plain copy from include/ppc440.h.
> >
> > Wolfgang, do you really think this is better than adding support for
> > this SoC into ppc440.h? After all, the CPU core of this SoC is still
> > a PPC4xx PowerPC.
>
> It makes no sense to duplicate common parts. Only different code
> should be moved to separate files.
>
[Marri] It is only few lines of code is different. Any way I will make a
change and
Send it.
Regards,
Marri
next prev parent reply other threads:[~2010-09-09 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 2:06 [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support tmarri at apm.com
2010-09-09 14:45 ` Stefan Roese
2010-09-09 14:53 ` Wolfgang Denk
2010-09-09 16:43 ` Tirumala Marri [this message]
2010-09-09 17:39 ` Stefan Roese
2010-09-09 17:41 ` Tirumala Marri
2010-09-09 18:01 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=761e2a44969fc6900a6e773118255351@mail.gmail.com \
--to=tmarri@apm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox